Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stable caching (and tests) for colocation compilation. #290

Closed
rwjblue opened this issue Sep 15, 2019 · 3 comments
Closed

Implement stable caching (and tests) for colocation compilation. #290

rwjblue opened this issue Sep 15, 2019 · 3 comments
Assignees
@rwjblue

Comments

@rwjblue
Copy link
Member

rwjblue commented Sep 15, 2019

The main implementation in #249 did the semi-naive thing of building the output tree every time without caching. Before we can enable this by default for all scenarios, we must implement a caching system that ensures the output tree is stable if none of the things changed here are modified.
@rwjblue rwjblue mentioned this issue Sep 15, 2019
Merged
@rwjblue rwjblue self-assigned this Sep 15, 2019
@rwjblue rwjblue mentioned this issue Oct 21, 2019
Closed
@rwjblue
Copy link
Member Author

rwjblue commented Dec 11, 2019

Done in #384

@rwjblue rwjblue closed this as completed Dec 11, 2019
@btecu
Copy link

btecu commented Dec 12, 2019

@rwjblue Was this actually implemented in #380?

@rwjblue
Copy link
Member Author

rwjblue commented Dec 12, 2019

Do'h 🤦‍♂, yes thank you @btecu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwjblue rwjblue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwjblue @btecu