Log and warn #12
Merged
Log and warn #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
log-and-warn
branch
2 times, most recently
from
32a3f76
to
4c8cccb
Compare
7 tasks
|
Thought it could maybe point someone in a direction to help fix the problem. Tried this: stefanpenner#1 |
|
@SlexAxton i suspect we should add a config option to opt out of the warning... |
|
Agree. But I assume it'd need to be propagated from |
two steps.
|
* always debug log sizes + times DEBUG=broccoli* will reveal this. * warn if the uglification took longer then 20,000ms
stefanpenner
force-pushed
the
log-and-warn
branch
from
4c8cccb
to
1bc871b
Compare
|
@ef4 r? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this warns after the build, which may not indicate why something is slow until too late.
It might be good to warn, before building. Maybe do to some file-size limit threshold. I am unclear what the threshold may be.
@SlexAxton ideas? If you have some, I would love a contribution to help improve this further.