Skip to content
This repository has been archived by the owner on Mar 31, 2019. It is now read-only.

Merge latest code from @kanjitalk755 #14

Closed
ianfixes opened this issue Mar 4, 2019 · 9 comments
Closed

Merge latest code from @kanjitalk755 #14

ianfixes opened this issue Mar 4, 2019 · 9 comments
Labels
meta Ops, chores, placeholders, decisions
Milestone

Comments

@ianfixes
Copy link
Member

ianfixes commented Mar 4, 2019

Refer to discussion at:
kanjitalk755/macemu#14

Bring in these edits, as they are the most current development of this project.

@ianfixes ianfixes added the meta Ops, chores, placeholders, decisions label Mar 4, 2019
@retokromer
Copy link
Contributor

@ianfixes When do you plan do to this? (I am asking because I would like to work on #8, but I don’t like to do useless work…)

@ianfixes
Copy link
Member Author

ianfixes commented Mar 9, 2019

I'm talking with one of the other devs about this. I've just discovered that there are a LOT of symlinked files between the 2 projects, and so at the moment the only sensible thing to do appears to be splitting off those common elements into a standalone libBasiliskII (or some such) and including it from both projects.

This is more or less the kind of rabbit hole I expected to encounter, but I'm prepared to sort it out.

In the immediate term, my plan is to start over from @kanjitalk755's repo (fix the symlinks, split the resulting repo), and then merge in the work that we've done here. I'm going to peek at that now

@retokromer
Copy link
Contributor

Thank you very much indeed for the information!

@ianfixes
Copy link
Member Author

I've captured stuff in #15 and my plan for now is to avoid accepting requests on any of those files unless/untill we establish a way to build those all from a shared location. That's going to put a lot of focus on refactoring instead of moving forward with new features, but I don't think the current setup is healthy for long-term maintenance.

@retokromer
Copy link
Contributor

I don't think the current setup is healthy for long-term maintenance.

I fully agree with you! I did add to #15 some historical context which could be useful.

@ianfixes
Copy link
Member Author

This is done, but it's very likely that I broke the builds in the process and will have to fix those as a top priority.

@ianfixes ianfixes added this to the Division milestone Mar 12, 2019
@DrLex0
Copy link
Contributor

DrLex0 commented Mar 12, 2019

@ianfixes Can you also include the latest commit that provides a different icon for SheepVM bundles?

@ianfixes
Copy link
Member Author

Hmm, looks like that got submitted after I started work on combining repos and splitting projects. I'm just going to pull the files in directly for now, and then my main concern will be the build tasks listed in kanjitalk755/macemu#14

@ianfixes
Copy link
Member Author

Done: 07cac57

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
meta Ops, chores, placeholders, decisions
Projects
None yet
Development

No branches or pull requests

3 participants