Use window-buffer-change-function hook #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable specifies functions called during redisplay when
window buffers have changed. The value should be a list of
functions that take one argument.
Functions specified buffer-locally are called for any window
showing the corresponding buffer if that window has been created or
assigned that buffer since the last time window change functions
were run. In this case the window is passed as argument.
I used more naively this hook for +2 years with in mind to contribute back
sometime. Unfortunately as time passed, I lost the memory of a reproductible
test case. I think I implemented this after seeing emacsorphanage#115 (Git gutter annotations
disappearing).
As I finally took the time to present you the hook, I realized that it would
mean to obsolete a bunch of functions and variables in the library such as:
- git-gutter:update-windows-commands
- git-gutter:pre-command-hook
- git-gutter:update-other-window-buffers
- git-gutter:post-command-hook
- git-gutter:quit-window
- git-gutter:switch-to-buffer
I also removed `git-gutter-mode` as it is generated by the minor mode and while
testing my changes, its presence caused a small bug of the mode not activating
when it should have.
seven-beep
force-pushed
the
window-buffer-change-functions
branch
from
a87ee7c to
f27a68f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used more naively this hook for +2 years with in mind to contribute back sometime. Unfortunately as time passed, I lost the memory of a reproducible test case. I think I implemented this after seeing #115 (Git gutter annotations disappearing).
As I finally took the time to present you the hook, I realized that it would mean to obsolete a bunch of functions and variables in the library such as:
I also removed the variable
git-gutter-modeas it is generated by the minor mode and while testing my changes, its presence caused a small bug of the mode not activating when it should have.