Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with show-paren-mode on unchanged hunks #150

Closed
kriansa opened this issue Oct 24, 2017 · 3 comments
Closed

Problem with show-paren-mode on unchanged hunks #150

kriansa opened this issue Oct 24, 2017 · 3 comments
Labels
bug a feature isn't working good first issue

Comments

@kriansa
Copy link

kriansa commented Oct 24, 2017

This is related to #114 and #115. When using git-gutter + show-paren-mode, it highlights the gutter with a weird color, but only on "unchanged" hunks.

image

I fixed that by copying your fix on #115:

(set-face-attribute 'git-gutter:unchanged nil :background nil :inherit 'default)

I'm not sure if this is a real fix, that's why I'm not opening a pull-request.

Thank you @syohex for this awesome package!

@gonewest818 gonewest818 added the bug a feature isn't working label Mar 24, 2020
@gonewest818
Copy link
Collaborator

That will be easy enough to change. Thank you for reporting!

@gonewest818
Copy link
Collaborator

I'm merging a fix for this; but note my default theme (zenburn) also overrides the definition of these faces, and while testing I temporarily disabled my theme to make sure I was seeing things the way the package intends.

@kriansa
Copy link
Author

kriansa commented Mar 26, 2020

This is awesome. Thanks @gonewest818 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a feature isn't working good first issue
Development

No branches or pull requests

2 participants