-
-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slow paredit #2537
Comments
I can tell I'm having the same issue but was thinking it's something with my emacs setup, but it seems other people are with this problem too. |
Did you confirm this happens even if lsp-mode is disabled? |
@yyoncho do you know how lsp-mode can slow down that? |
I had typo in the |
Not sure, is the performance issue related to clojure-lsp? enable |
AFAICS this is cased by indent-region call which paredit does after slurp. |
with lsp-log-io I see message trace in the lsp-log buffer. Don't see log-io buffer ...
here is excerpt from the log
|
I think the log is missing the "textDocument/rangeFormatting" request(s). |
hm, weird.
|
AFAICS the issue is in clojure-lsp Emacs/lsp-mode tries to format a small region but the server sends reformatting of all(?) forms. |
Hum, the server seems to be sending the range correctly: https://github.com/clojure-lsp/clojure-lsp/blob/master/src/clojure_lsp/handlers.clj#L362 |
@gdanov do you have a sample file where we can test that? |
anything basic and big enough works. No idea if .clj vs .cljc makes difference. here is basic file that reproduces the performance problem (when ~2k lines).
|
Ok, thanks, I'll look on clojure-lsp side after we merge this huge refactor that we are WIP this week clojure-lsp/clojure-lsp#261 |
wow, that's serious work. issue created as you requested |
I am closing this since it seems like there is nothing to do on lsp-mdoe side. |
Describe the bug
when using clojure-lsp and paredit, paredit operations are very slow (few seconds)
To Reproduce
emacs 27.1, latest lsp-mode and clojure-lsp, lsp-enable-identation nil, open clojure file, wait for lsp server to initialize and slurp-sexp for example
Which Language Server did you use
clojure-lsp
OS
osx
Error callstack
here is the output of emacs profiler
here is my initialization of lsp-mode
The text was updated successfully, but these errors were encountered: