elsa--get-requires fails to process "cl-macs.el.gz" due to syntax-ppss
#226
Comments
|
It seems that guarding the match data with (let ((syntax-ppss-data (save-match-data (syntax-ppss))))
(unless (or (nth 4 syntax-ppss-data)
(and (< 0 (car syntax-ppss-data))
(not (and (= 1 (car syntax-ppss-data))
(save-excursion
(backward-up-list)
(down-list)
(looking-at-p "eval-"))))) )
(let* ((library-name (match-string 1))
(library (elsa--find-dependency library-name)))
(when library
(push (list library library-name) this-file-requires))))
) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm running into a weird error with Elsa v20230621.1005 MELPA:
throws error
wrong-type-argument stringp nil, and it turns out it's the matchedlibrary-namethat becomesnilunexpectedly during the process of finding the required libraries.Further digging shows that, the first required library
"cl-lib"is processed successfully. However, after matching the second required library,"macroexp",(match-string 1)seems to be invalidated (evaluates tonilinstead of"macroexp") after the(syntax-ppss)call inElsa/elsa-dependencies.el
Line 92 in f719e24
Interestingly, in debugger, if I stop right before line 92 and evaluate
(syntax-ppss)manually from debugger,(match-string 1)would not be changed tonilafter line 92, and the whole function call can be successful if such manual evaluation is done to "guard" each matched string. Adding a dummy(syntax-ppss)call before line 92, however, will only invalidates(match-string 1)even earlier. It seems that only the interactive evaluation from debugger could "guard" the match.I could not make the debugger step into
syntax-ppssto further understand what's happening.As the file path suggests, my platform is "emacsmacport" 29.1 installed with Homebrew on macOS.
[1] For convenience, the link to cl-macs.el is https://github.com/emacs-mirror/emacs/blob/master/lisp/emacs-lisp/cl-macs.el
The text was updated successfully, but these errors were encountered: