Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aeacus may not remove the README config file properly #143

Closed
safinsingh opened this issue Jul 16, 2022 · 4 comments
Closed

Aeacus may not remove the README config file properly #143

safinsingh opened this issue Jul 16, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@safinsingh
Copy link
Collaborator

As of #138, the ReadMe.conf file can have the names {readme,ReadMe,README}.conf. This causes an issue during release because aeacus currently assumes that the file is named ReadMe.conf (see: https://github.com/elysium-suite/aeacus/blob/master/release_linux.go#L65).

@safinsingh safinsingh added the bug Something isn't working label Jul 16, 2022
@Mobmaker55 Mobmaker55 self-assigned this Jul 16, 2022
@Mobmaker55
Copy link
Collaborator

As a secondary point, why is there so much being removed in release_linux.go ? A production build only needs to remove misc/, LICENSE, the .conf files, and aeacus itself ?
(see: https://github.com/elysium-suite/aeacus/blob/master/release_linux.go#L66)

@sourque
Copy link
Collaborator

sourque commented Jul 17, 2022

I think it's insurance against someone dropping using a dev build or full repo-- especially if someone wrote custom obfuscation/crypto stuff (and maybe checked it into git), we want to remove it on release.

@Mobmaker55
Copy link
Collaborator

Isn't that the end user's problem though? Also, it seems like bad practice to be compiling in /opt/aeacus in general...

@sourque
Copy link
Collaborator

sourque commented Jul 17, 2022

Yeah, I suppose. But in the end, solving an end-user problem is what the project does :^) I figure if we can save somebody the trouble without making our code more complex or error-prone then it's worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants