`set.headers` ignored when Elysia is bundled #625

einar-hjortdal · 2024-05-01T08:22:59Z

What version of Elysia.JS is running?

1.0.15

What platform is your computer?

Linux 5.14.0-362.24.1.el9_3.x86_64 x86_64 x86_64

What steps can reproduce the bug?

import Elysia from 'elysia'

function myHandler (ctx) {
  try {
    const body = `<!DOCTYPE html><head></head><body>HTML</body>`
    ctx.set.headers['Content-Type'] = 'text/html; charset=utf-8'
    return body
  } catch (err) {
    console.error(err)
  }
}

export function tryFiles (ctx, publicDir, handler) {
  if (ctx.path === '/') {
    return handler(ctx)
  }

  const absolutePath = join(process.cwd(), publicDir, ctx.path)

  const file = Bun.file(absolutePath)
  if (file.size === 0) {
    return handler(ctx)
  }

  return file
}

new Elysia()
  .get('*', ctx => {
    if (process.env.BUN_ENV === 'production') {
      return myHandler(ctx)
    }
    return tryFiles(ctx, 'build/browser', myHandler)
  })
  .on('start', () => console.log(`Running on port ${process.env.PORT}`))
  .listen(process.env.PORT)

This code works as intended when run by Bun without bundling.
If this code is bundled bun build ./index.js --outdir ./build --target=bun --public-path /_statics/ then the browser receives Content-Type text/plain instead of text/html

{
  "name": "elysia-bugs",
  "module": "index.js",
  "type": "module",
  "devDependencies": {
    "@types/bun": "latest"
  },
  "scripts": {
    "build": "bun build ./index.js --outdir ./build --target=bun --public-path /_statics/",
    "dev": "bun run build && PORT=8080 BUN_ENV=production bun run build/index.js",
    "start": "bun run build && PORT=8080 bun run build/index.js"
  },
  "peerDependencies": {
    "typescript": "^5.0.0"
  },
  "dependencies": {
    "elysia": "^1.0.15"
  }
}

I need the bundle to work, please help me

What is the expected behavior?

built and not-built app work the same

What do you see instead?

built app is broken

Additional information

This may be a problem with bun:
In my debugging journey, I have combined the functions 2 handlers above (tryFiles and myHandler) into one and this issue disappears. However, when using the --minify flag, the same issue appears again.

The text was updated successfully, but these errors were encountered:

bogeychan · 2024-05-13T14:02:33Z

@Coachonko, as a workaround, you can set new Elysia({ aot: false }).

@SaltyAom, inferBodyReference needs a whole rewrite to be more robust.

this line only checks for myHandler(ctx)

elysia/src/sucrose.ts

Lines 415 to 416 in 968650b

    
           // ! Function is passed to another function, assume as all is accessed 
        
           if (code.includes('(' + alias + ')')) {

and not these cases:

myHandler("", ctx)
myHandler(ctx, "")
myHandler("", ctx, "")
myHandler( ctx )
myHandler( ctx , "" )
myHandler( "" , ctx )
myHandler( "" , ctx , "" )

Bun build turns the code in something like this:

var myHandler = function (ctx) {
	try {
		const body = `<!DOCTYPE html><head></head><body>HTML</body>`
		ctx.set.headers['Content-Type'] = 'text/html; charset=utf-8'
		return body
	} catch (err) {
		console.error(err)
	}
}
function tryFiles(ctx, publicDir, handler5) {
	if (ctx.path === '/') {
		return handler5(ctx)
	}
	const absolutePath = join(process.cwd(), publicDir, ctx.path)
	const file = Bun.file(absolutePath)
	if (file.size === 0) {
		return handler5(ctx)
	}
	return file
}
new Elysia()
	.get('*', (ctx) => {
		if (false) {
		}
		return tryFiles(ctx, 'build/browser', myHandler)
	})
	.on('start', () => console.log(`Running on port 8080`))
	.listen(8080)

thejasonxie · 2024-05-16T02:55:12Z

@Coachonko, as a workaround, you can set new Elysia({ aot: false }).

@SaltyAom, inferBodyReference needs a whole rewrite to be more robust.

this line only checks for myHandler(ctx)

elysia/src/sucrose.ts

Lines 415 to 416 in 968650b

    
           // ! Function is passed to another function, assume as all is accessed 
        
           if (code.includes('(' + alias + ')')) {

and not these cases:

* `myHandler("", ctx)`

* `myHandler(ctx, "")`

* `myHandler("", ctx, "")`

* `myHandler(     ctx     )`

* `myHandler(     ctx     ,     ""     )`

* `myHandler(     ""     ,     ctx     )`

* `myHandler(     ""     ,     ctx     ,     ""     )`

Bun build turns the code in something like this:

var myHandler = function (ctx) {
	try {
		const body = `<!DOCTYPE html><head></head><body>HTML</body>`
		ctx.set.headers['Content-Type'] = 'text/html; charset=utf-8'
		return body
	} catch (err) {
		console.error(err)
	}
}
function tryFiles(ctx, publicDir, handler5) {
	if (ctx.path === '/') {
		return handler5(ctx)
	}
	const absolutePath = join(process.cwd(), publicDir, ctx.path)
	const file = Bun.file(absolutePath)
	if (file.size === 0) {
		return handler5(ctx)
	}
	return file
}
new Elysia()
	.get('*', (ctx) => {
		if (false) {
		}
		return tryFiles(ctx, 'build/browser', myHandler)
	})
	.on('start', () => console.log(`Running on port 8080`))
	.listen(8080)

The workaround works but leads into other issues like mapResponse not working properly when gzipping. An issue was opened about this #638

Hope this can be fixed soon! Thanks!

thejasonxie · 2024-05-16T04:05:57Z

Another issue for when aot:false, is that when using the error function in the onBeforeHandle for authentication, we get
"undefined is not a function (near '...error32...')"

desplmfao · 2024-05-22T07:26:52Z

im not sure if this is a part of being bundled but i am having issues with setting headers in onError (it doesnt set any headers, ctx.set.headers logs the proper headers)

disabling aot fixes this too ^

SaltyAom · 2024-07-02T12:26:45Z

Should be fixed on ea5d133, to be released in 1.1

Please leave this issue until 1.1 stable is released

einar-hjortdal added the bug Something isn't working label May 1, 2024

einar-hjortdal mentioned this issue May 2, 2024

[macro] minify breaks object equality oven-sh/bun#7196

Open

SaltyAom added the pending Should be resolved in next release label Jul 2, 2024

SaltyAom closed this as completed Aug 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`set.headers` ignored when Elysia is bundled #625

`set.headers` ignored when Elysia is bundled #625

einar-hjortdal commented May 1, 2024 •

edited

Loading

bogeychan commented May 13, 2024 •

edited

Loading

thejasonxie commented May 16, 2024 •

edited

Loading

thejasonxie commented May 16, 2024

desplmfao commented May 22, 2024 •

edited

Loading

SaltyAom commented Jul 2, 2024

set.headers ignored when Elysia is bundled #625

set.headers ignored when Elysia is bundled #625

Comments

einar-hjortdal commented May 1, 2024 • edited Loading

What version of Elysia.JS is running?

What platform is your computer?

What steps can reproduce the bug?

What is the expected behavior?

What do you see instead?

Additional information

bogeychan commented May 13, 2024 • edited Loading

thejasonxie commented May 16, 2024 • edited Loading

thejasonxie commented May 16, 2024

desplmfao commented May 22, 2024 • edited Loading

SaltyAom commented Jul 2, 2024

`set.headers` ignored when Elysia is bundled #625

`set.headers` ignored when Elysia is bundled #625

einar-hjortdal commented May 1, 2024 •

edited

Loading

bogeychan commented May 13, 2024 •

edited

Loading

thejasonxie commented May 16, 2024 •

edited

Loading

desplmfao commented May 22, 2024 •

edited

Loading