Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Add support for Fine-Grained Control of Authorization #247

Closed
fracek opened this issue Apr 25, 2020 · 3 comments
Closed

Add support for Fine-Grained Control of Authorization #247

fracek opened this issue Apr 25, 2020 · 3 comments
Assignees
Milestone

Comments

@fracek
Copy link
Collaborator

fracek commented Apr 25, 2020

CAP 18 changed the data type for the attribute authorize in AllowTrustOp. It is now a uint32 instead of a boolean. It also includes a new TrustLineFlag which is authorizedToMaintainLiabilitiesFlag with value 2.

You can see the implementation in js-stellar-base here, which still accepts booleans but converts the value to an uint32.

This is part of #246

@fracek fracek added this to the Protocol 13 milestone Apr 25, 2020
@Kirbyrawr
Copy link
Collaborator

Since we added the authorizedToMaintainLiabilities in other places i will follow the Java's code instead as i think is more easy to read.
https://github.com/stellar/java-stellar-sdk/pull/276/files#diff-dc1e56016276f11d48a7766517a79e9bR69

@Kirbyrawr
Copy link
Collaborator

I believe it's only these changes
#250

@fracek
Copy link
Collaborator Author

fracek commented Apr 28, 2020

Fixed by #250

@fracek fracek closed this as completed Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants