#6161 ComputeBookmarkHash in HttpWorkflowsMiddleware #6407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating custom triggers, the system uses activityTypeName to generate a hash. However, when the trigger is invoked, it searches through all the hashes in the database but does not use the activityTypeName of the trigger itself (for good reason, as it does not have access to it). Instead, it defaults to using the activityTypeName of HttpEndpoint.
As a result, it's not possible to create custom triggers with an activityTypeName different from HttpEndpoint, which leads to issues.
It is also mentioned here: #6161
This change is