Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Solved] getSongs() returns relative path #6

Closed
SimonIT opened this issue Jul 7, 2020 · 8 comments
Closed

[Solved] getSongs() returns relative path #6

SimonIT opened this issue Jul 7, 2020 · 8 comments
Labels
bug Something isn't working

Comments

@SimonIT
Copy link

SimonIT commented Jul 7, 2020

Describe the bug
getSongs() returns relative paths to the individual songs

To Reproduce

    api = azapi.AZlyrics('duckduckgo', accuracy=0.5)

    api.artist = "Oliver Heldens"
    api.title = "Lift Me Up"

    songs = api.getSongs()

Expected behavior
The url is https://www.azlyrics.com/lyrics/oliverheldens/liftmeup.html

Screenshots
image

Desktop (please complete the following information):

  • Version 3.0.0
@elmoiv elmoiv added the good first issue Good for newcomers label Jul 7, 2020
@elmoiv
Copy link
Owner

elmoiv commented Jul 7, 2020

Thanks. I will work on a fix

@elmoiv
Copy link
Owner

elmoiv commented Jul 7, 2020 •
edited
Loading

@SimonIT
I patched a workaround for this bug. Now pip install azapi==3.0.1
Check it out and if your problem is solved, kindly close this issue :)

@elmoiv elmoiv added bug Something isn't working and removed good first issue Good for newcomers labels Jul 7, 2020
@SimonIT
Copy link
Author

SimonIT commented Jul 7, 2020

Yes, it's fixed. Thank you

@SimonIT SimonIT closed this as completed Jul 7, 2020
@elmoiv elmoiv changed the title getSongs() returns relative path [Solved] getSongs() returns relative path Aug 14, 2020
@SimonIT
Copy link
Author

SimonIT commented Jan 1, 2022

Hey @elmoiv,
the problem somehow returned. I'm using version 3.0.6
image

@SimonIT SimonIT reopened this Jan 1, 2022
@elmoiv
Copy link
Owner

elmoiv commented Jan 2, 2022

Can you please send the code producing this bug?

@SimonIT
Copy link
Author

SimonIT commented Jan 2, 2022

You can use the code from the first comment or this:
https://github.com/SimonIT/spotifylyrics/blob/a7d8df22f6398e50d49ef2300714d409bbf42905/services.py#L319-L342

@elmoiv
Copy link
Owner

elmoiv commented Jan 2, 2022

@SimonIT
Bug Patched.
Now pip install azapi==3.0.7 and check if it's resolved at your side.

@SimonIT
Copy link
Author

SimonIT commented Jan 3, 2022

It's working again, thanks!
I wouldn't mind if the url would start with 'https', but that's only a minor detail

@SimonIT SimonIT closed this as completed Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonIT @elmoiv