Skip to content
This repository was archived by the owner on Jan 21, 2024. It is now read-only.

Log and fix issues discovered creating sbstr8.lizmars.net #55

Open
elmarsto opened this issue Jul 9, 2023 · 9 comments
Open

Log and fix issues discovered creating sbstr8.lizmars.net #55

elmarsto opened this issue Jul 9, 2023 · 9 comments

Comments

@elmarsto
Copy link
Owner

elmarsto commented Jul 9, 2023

I found numerous usability and other bugs in building s8home. I generally fixed them by modifying sbstr8 upstream in a separate neovim tab, but some of them I fixed in-place and tagged FIXME.

I need to go through the s8home codebase, extract TODOs and FIXMEs, and also compare its sbstr8 directory against upstream to find all the places that need fixing.

@elmarsto
Copy link
Owner Author

elmarsto commented Jul 9, 2023

Here are a couple off the top of my head:

  • PageHeader should be pulled in once, by app/layout.tsx, and not from several different locations, I think? This would make it much, much harder to have completely unstyled pages, but it's just so messy as it stands
  • Remove font stack from style.css. It fights with any theme.css the user creates. Unnecessary and against our minimal-style principle for the unthemed product.
  • Lede and LedeList should use the lib/defaults and overrides, as it currently stands in s8home, it is all hardwired constants

@elmarsto
Copy link
Owner Author

elmarsto commented Jul 9, 2023

also the atom generator disregards custom postPath in config and also doesn't respect overrides and also does not use lib/default
(grrr)

@elmarsto
Copy link
Owner Author

elmarsto commented Jul 9, 2023

also the metadata stuff breaks if a post does not have an image, whew this is a lot of bug

@elmarsto
Copy link
Owner Author

elmarsto commented Jul 9, 2023

post/standard layout renders in a daft way if no image is present

@elmarsto
Copy link
Owner Author

elmarsto commented Jul 9, 2023

same for ledelist

@elmarsto
Copy link
Owner Author

elmarsto commented Jul 9, 2023

lib/post is not returning anything sane (instead returns nonexistent 'image.png') when an image is not present

@elmarsto
Copy link
Owner Author

elmarsto commented Jul 9, 2023

on standard article layout, usernames should be links to the url of the user if present

@elmarsto
Copy link
Owner Author

elmarsto commented Jul 9, 2023

if you remove the image from meta.json then typescript type inference freaks out. We need to specify the metadata datatype

@elmarsto
Copy link
Owner Author

elmarsto commented Jul 9, 2023

image prop should be optional on post/standard

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant