Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two emails per reminder are sent #187

Closed
Node815 opened this issue Mar 4, 2024 · 15 comments · Fixed by #239
Closed

Two emails per reminder are sent #187

Node815 opened this issue Mar 4, 2024 · 15 comments · Fixed by #239
Assignees
Labels
bug Something isn't working Can reproduce I can reproduce the bug Completed Feature is implemented and merged

Comments

@Node815
Copy link

Node815 commented Mar 4, 2024

For some reason, I get two emails from "Wallos Notification" for each subscription up for renewal. The Docker Logs, I'm afraid are very sparse and don't indicate why. My emails were sent at 09:00:00 during this cycle:

image

I can log into the container, but if you tell me where the email logs are stored, I can grab those for you.

@ellite
Copy link
Owner

ellite commented Mar 4, 2024

Hi.Thank you for the report.
Are you getting both emails for the same subscriptions?

@Node815
Copy link
Author

Node815 commented Mar 4, 2024

Yes for the same subscription. To the same inbox.

@ellite
Copy link
Owner

ellite commented Mar 4, 2024

Thanks. I'll try to figure out what's happening.

@NightHawkATL
Copy link

NightHawkATL commented Mar 6, 2024

I am seeing this also.
image
Same subscription and sending twice. These are my first 2 notifications since installing.

@Node815
Copy link
Author

Node815 commented Mar 6, 2024

For what it's worth, there were no duplicates in the database when I explored it using a database explorer so that could probably be ruled out as a suspect.

@ellite
Copy link
Owner

ellite commented Mar 6, 2024

If you have household members without an email address set, the email will be sent to the email defined on the account.

But I'm assuming that this is not the case.

Couldn't find the issue yet.

@NightHawkATL
Copy link

just one user here.

@Node815
Copy link
Author

Node815 commented Mar 6, 2024

If you have household members without an email address set, the email will be sent to the email defined on the account.

But I'm assuming that this is not the case.

Couldn't find the issue yet.

I have two other household members, but their e-mail is not provided in the app. I have mine as the primary go to email for the notifications and planned on using a universal inbox for those down the road soon.

@ellite
Copy link
Owner

ellite commented Mar 10, 2024

Just an update. I haven't found the issue yet.

@NightHawkATL
Copy link

I did add a second person and then remove them. Maybe the removal didn't remove them from the notifications?

@ridizy
Copy link

ridizy commented Mar 18, 2024

I am receiving duplicate e-mails as well. I have two other members of my household and neither has an e-mail address set. The duplicate e-mails are being sent to me for a subscription that is "Paid by" me.

@ellite
Copy link
Owner

ellite commented Mar 18, 2024

I believe the issue is that the cronjobs are running twice.
Once as the user and once as the system:

/var/www/html # crontab -l
# Run the scripts every day
0 1 * * * /usr/local/bin/php /var/www/html/endpoints/cronjobs/updatenextpayment.php >> /var/log/cron/updatenextpayment.log 2>&1
0 2 * * * /usr/local/bin/php /var/www/html/endpoints/cronjobs/updateexchange.php >> /var/log/cron/updateexchange.log 2>&1
0 9 * * * /usr/local/bin/php /var/www/html/endpoints/cronjobs/sendnotifications.php >> /var/log/cron/sendnotifications.log 2>&1
/var/www/html # cat /etc/cron.d/cronjobs
# Run the scripts every day
0 1 * * * /usr/local/bin/php /var/www/html/endpoints/cronjobs/updatenextpayment.php >> /var/log/cron/updatenextpayment.log 2>&1
0 2 * * * /usr/local/bin/php /var/www/html/endpoints/cronjobs/updateexchange.php >> /var/log/cron/updateexchange.log 2>&1
0 9 * * * /usr/local/bin/php /var/www/html/endpoints/cronjobs/sendnotifications.php >> /var/log/cron/sendnotifications.log 2>&1

I'll try to fix this.

@ellite ellite linked a pull request Mar 18, 2024 that will close this issue
@ellite ellite added bug Something isn't working Can reproduce I can reproduce the bug Completed Feature is implemented and merged labels Mar 18, 2024
@ellite ellite self-assigned this Mar 18, 2024
@ellite
Copy link
Owner

ellite commented Mar 18, 2024

Just released 1.17.1 that disabled the cronjobs for the user, so they don't run twice.
Hopefully this fixes it 🤞

@ridizy
Copy link

ridizy commented Mar 20, 2024

I just had a reminder fire today, and I only received it once. Thank you!

@ellite
Copy link
Owner

ellite commented Mar 20, 2024

Perfect.
Thanks for confirming.

@ellite ellite closed this as completed Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Can reproduce I can reproduce the bug Completed Feature is implemented and merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants