Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check consistency of all tooltips with the function that the button provides #5

Closed
pinarpink opened this issue Jun 15, 2019 · 4 comments
Assignees
Milestone

Comments

@pinarpink
Copy link
Member

pinarpink commented Jun 15, 2019

  • Add dataset --> ambiguous label (Data of this project vs dataset in the "+" hint text)
  • Storage location (title), data file ("+" hint)
@pinarpink pinarpink added this to the m_01 milestone Jun 15, 2019
@pinarpink pinarpink self-assigned this Jul 6, 2019
@pinarpink pinarpink reopened this Jul 29, 2019
@pinarpink pinarpink assigned vildead and unassigned pinarpink Jul 30, 2019
@vildead
Copy link
Member

vildead commented Jul 30, 2019

looks good. Just minor comments:

  • Project page - all tooltips are in format "Add X to project" but only box for Data of this project has tooltip "Add new dataset to project"
  • Dataset page - all tooltips are in format "Add new X" which is not consistent with project tooltips.
  • Partner page - tooltip on main "Edit icon" is missing

@vildead vildead assigned pinarpink and unassigned vildead Jul 30, 2019
@pinarpink
Copy link
Member Author

pinarpink commented Jul 30, 2019

@vildead
I tried to reflect the subtle differences in button function. Whenever a plus button immediately launches an entity creation modal the tooltip begins with "add new". This is the case for all cards in the dataset page. In the project page, however, there are alternative ways to add things (e.g. link existing Personnel and Contacts to the project) so I wanted to differentiate. In the future we will also be able to link existing documents and contracts to the project. I am open to suggestions. But there is a difference.

I will add the "...to dataset" prefix to the dataset page tips.
Partner page, ok will do

@pinarpink
Copy link
Member Author

you can re-check on f9f810d

@pinarpink pinarpink assigned vildead and unassigned pinarpink Jul 30, 2019
@vildead
Copy link
Member

vildead commented Jul 31, 2019

closing the issue. Verified on commit: c4014c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants