Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importer fails on current schema #338

Closed
vildead opened this issue Apr 15, 2022 · 0 comments · Fixed by #367
Closed

Importer fails on current schema #338

vildead opened this issue Apr 15, 2022 · 0 comments · Fixed by #367
Assignees
@vildead
Labels
blocker The issue is of most importance

Comments

@vildead
Copy link
Member

vildead commented Apr 15, 2022

According to schema, there is not locations key in the storage. Just location.

daisy/core/importer/datasets_importer.py

Line 152 in 77f836a

location_delimeted = '\n'.join(storage_location_dict['locations'])

daisy/core/fixtures/json_schemas/elu-dataset.json

Line 47 in 77f836a

"location": {"type": "string"},

@vildead vildead added the blocker The issue is of most importance label Apr 15, 2022
@vildead vildead self-assigned this Apr 15, 2022
@vildead vildead mentioned this issue Jul 26, 2022
Merged
@vildead vildead mentioned this issue Sep 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vildead vildead

Labels
blocker The issue is of most importance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: importer looks for right key for storage location elixir-luxembourg/daisy
1 participant
@vildead