Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link LCSB Identifier service to DAISY #227

Closed
4 tasks
pinarpink opened this issue May 31, 2021 · 0 comments · Fixed by #243
Closed
4 tasks

Link LCSB Identifier service to DAISY #227

pinarpink opened this issue May 31, 2021 · 0 comments · Fixed by #243
Assignees
Labels
blocker The issue is of most importance wip Work In Progress

Comments

@pinarpink
Copy link
Member

pinarpink commented May 31, 2021

The following needs to be done

  • Add LCSB Identifier service client to DAISY. Should generate the call curl -X POST -H "Content-Type: application/json" -d '{"entity":"dataset", "name":"test-1"}' http://10.240.16.199:8080/v1/api/id/

  • Add the LCSB Identifier sevrice as an alternative option to the default postgres counter based ID service. Proposed config params are POST_PUBLISH_FUNCTION = daisy.core.set_default_id POST_PUBLISH_FUNCTION = daisy.core.lcsb.set_id_from_idservice

  • Check that the publish button appears correctly on Project, Dataset, Cohort and Partner pages.

  • Check that the identifier field record overview page. ID will be editable by admin via the Django admin page.

@pinarpink pinarpink added the blocker The issue is of most importance label May 31, 2021
@pinarpink pinarpink added this to the ELIXIR End2End M1 milestone May 31, 2021
@jLebioda jLebioda added the wip Work In Progress label Jun 7, 2021
@vildead vildead linked a pull request Jun 24, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker The issue is of most importance wip Work In Progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants