Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accession number should be unique #142

Closed
pinarpink opened this issue Mar 16, 2020 · 1 comment · Fixed by #269
Closed

Accession number should be unique #142

pinarpink opened this issue Mar 16, 2020 · 1 comment · Fixed by #269
Assignees

Comments

@pinarpink
Copy link
Member

pinarpink commented Mar 16, 2020

Describe the bug (current behaviour)

Several problems with the accession number field. It is defined as not nullable and with a default value of "-".
As a result when new partners/cohorts are added but not published they all get the accession number of "-".

This field should be nullable, without a default value. An entity should receive an accession number only when it is published.

To reproduce

  1. Go to http://daisy.lcsb.uni.lu/api/partners
  2. Partners with acronym "EURICE" and "FIBAO-GENYO" have the same accession number of "-"

Expected behavior

All partners delivered from the api endpoint should have a unique accession number.

Environment:

  • Deployment: daisy.lcsb.uni.lu
  • Version 1.2.0

Additional information (error logs, screenshots)

@vildead
Copy link
Member

vildead commented Apr 15, 2021

it will be solved by indetifier service

@pinarpink pinarpink added this to the ELIXIR End2End M1 milestone Jun 3, 2021
@vildead vildead linked a pull request Jul 29, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants