Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to update Access definitions of a Dataset #10

Closed
pinarpink opened this issue Jun 15, 2019 · 3 comments
Closed

Add ability to update Access definitions of a Dataset #10

pinarpink opened this issue Jun 15, 2019 · 3 comments
Assignees
Milestone

Comments

@pinarpink
Copy link
Member

No description provided.

@pinarpink pinarpink added this to the m_02 milestone Jun 15, 2019
@pinarpink pinarpink modified the milestones: m_02, m_01 Jul 16, 2019
@pinarpink pinarpink reopened this Jul 22, 2019
@pinarpink pinarpink self-assigned this Jul 28, 2019
@vildead
Copy link
Member

vildead commented Jul 29, 2019

@pinarpink I can update the access logged as admin. When I am logged as any other user including VIP user with all priviledges, I can't edit access - I am getting blank box with Edit access definition written in it.
Log:

WARNING 2019-07-29 20:31:01,700 log 31490 140532733605696 Forbidden (Permission denied): /dataset/1/access/1/edit
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.6/site-packages/django/core/handlers/base.py", line 126, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/usr/local/lib/python3.6/site-packages/django/core/handlers/base.py", line 124, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/daisy/daisy/core/permissions/checker.py", line 182, in wrapper
    raise PermissionDenied
django.core.exceptions.PermissionDenied
WARNING 2019-07-29 20:31:01,700 log 31490 140532733605696 Forbidden (Permission denied): /dataset/1/access/1/edit
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.6/site-packages/django/core/handlers/base.py", line 126, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/usr/local/lib/python3.6/site-packages/django/core/handlers/base.py", line 124, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/daisy/daisy/core/permissions/checker.py", line 182, in wrapper
    raise PermissionDenied
django.core.exceptions.PermissionDenied

commit 78b6296

@pinarpink
Copy link
Member Author

dear @vildead I have committed a fix for this permission bug. It was not to do with the page logic, but with the data loader, which did not associate dataset permissions with local custodians.

In order to verify we have two options. Either go to the permissions view page and then save ( no changes necessary). Or drop the database and load_demo_data again. cheers

@pinarpink pinarpink assigned vildead and unassigned pinarpink Jul 31, 2019
@vildead
Copy link
Member

vildead commented Aug 2, 2019

closing the issue. verified on commit: 425fc26

@vildead vildead closed this as completed Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants