From 96bbe144bfe2120e4b5ea5553093e468f8d3b5d6 Mon Sep 17 00:00:00 2001 From: Jacek Lebioda Date: Wed, 5 Feb 2020 16:47:23 +0100 Subject: [PATCH 01/21] feat: visual improvements on search results, corrected layout on about page --- web/templates/about.html | 2 +- web/templates/search/_items/cohorts.html | 17 +++++++---------- web/templates/search/_items/contacts.html | 16 +++++++--------- web/templates/search/_items/contracts.html | 13 +++++-------- web/templates/search/_items/datasets.html | 17 ++++++++--------- web/templates/search/_items/partners.html | 21 ++++++++++----------- web/templates/search/_items/projects.html | 15 +++++++-------- 7 files changed, 45 insertions(+), 56 deletions(-) diff --git a/web/templates/about.html b/web/templates/about.html index 73d8cd01..11d65078 100644 --- a/web/templates/about.html +++ b/web/templates/about.html @@ -8,7 +8,7 @@

About

-
+
diff --git a/web/templates/search/_items/cohorts.html b/web/templates/search/_items/cohorts.html index c21c7ecd..2e8eff26 100644 --- a/web/templates/search/_items/cohorts.html +++ b/web/templates/search/_items/cohorts.html @@ -1,23 +1,23 @@ {% for cohort in data.cohorts %}
-
+

- {{ cohort.title }} + {{ cohort.title }}

    -
  • Owners: {% for contact in cohort.owners %} +
  • Owners: {% for contact in cohort.owners %} {{ contact }} {% empty %} "unknown" {% endfor %}
  • -
  • Institutes: {% for institute in cohort.institutes %} +
  • Institutes: {% for institute in cohort.institutes %} {{ institute }} {% empty %} "unknown" {% endfor %}
  • -
  • Ethics Confirmation: {% if cohort.ethics_confirmation %} - +
  • Ethics Confirmation: {% if cohort.ethics_confirmation %} + check {% else %} @@ -25,13 +25,10 @@

    {% endif %}

- Details + Details »
{% empty %}

No results

{% endfor %} - - - diff --git a/web/templates/search/_items/contacts.html b/web/templates/search/_items/contacts.html index 77a7f559..8452b33d 100644 --- a/web/templates/search/_items/contacts.html +++ b/web/templates/search/_items/contacts.html @@ -1,29 +1,27 @@ {% for contact in data.contacts %}
-
+

- {{ contact.first_name }} {{ contact.last_name }} + {{ contact.first_name }} {{ contact.last_name }}

    -
  • Role: {{ contact.type }} +
  • + Role: {{ contact.type }}
  • -
  • Affiliation(s): +
  • Affiliation(s): {% for partner in contact.partners %} {{ partner }} {% empty %} - "-" + - {% endfor %}
- Details + Details »
{% empty %}

No results

{% endfor %} - - - diff --git a/web/templates/search/_items/contracts.html b/web/templates/search/_items/contracts.html index cae555f4..20bdf51f 100644 --- a/web/templates/search/_items/contracts.html +++ b/web/templates/search/_items/contracts.html @@ -1,24 +1,21 @@ {% for contract in data.contracts %}
-
+

- {{ contract.partners | join:", " }} + {{ contract.partners | join:", " }}

    -
  • Project: {{ contract.project }}
  • +
  • Project: {{ contract.project }}
  • {% if contract.partners_roles %} -
  • Partners roles: {{ contract.partners_roles | join:", " }}
  • +
  • Partners roles: {{ contract.partners_roles | join:", " }}
  • {% endif %}
- Details + Details »
{% empty %}

No results

{% endfor %} - - - diff --git a/web/templates/search/_items/datasets.html b/web/templates/search/_items/datasets.html index c71a80f4..c6231e0a 100644 --- a/web/templates/search/_items/datasets.html +++ b/web/templates/search/_items/datasets.html @@ -1,30 +1,29 @@ {% for dataset in data.datasets %}
-
+
-

{{ dataset.title }}

+

+ {{ dataset.title }} +

    -
  • Published: {{ dataset.is_published | yesno }}
  • -
  • Datatypes: +
  • Published: {{ dataset.is_published | yesno }}
  • +
  • Datatypes: {% for datatype in dataset.data_types %} {{ datatype }} {% endfor %}
  • {% if dataset.local_custodians %} -
  • Local custodians: +
  • Local custodians: {% for local_custodian in dataset.local_custodians %} {{ local_custodian }} {% endfor %}
  • {% endif %}
- Details + Details »
{% empty %}

No results

{% endfor %} - - - diff --git a/web/templates/search/_items/partners.html b/web/templates/search/_items/partners.html index a94a6e19..0cd25537 100644 --- a/web/templates/search/_items/partners.html +++ b/web/templates/search/_items/partners.html @@ -1,28 +1,27 @@ {% for partner in data.partners %}
-
+

- {{ partner.name }} {% if partner.acronym %}({{ partner.acronym }}){% endif %} - {% if partner.is_clinical %} - local_hospital - {% endif %} + + {{ partner.name }} {% if partner.acronym %}({{ partner.acronym }}){% endif %} + {% if partner.is_clinical %} + local_hospital + {% endif %} +

    -
  • Geo-Category: +
  • Geo-Category: {{ partner.geo_category }}
  • -
  • Sector: +
  • Sector: {{ partner.sector_category }}
- Details + Details »
{% empty %}

No results

{% endfor %} - - - diff --git a/web/templates/search/_items/projects.html b/web/templates/search/_items/projects.html index 6df7a4be..b5b29c50 100644 --- a/web/templates/search/_items/projects.html +++ b/web/templates/search/_items/projects.html @@ -1,22 +1,21 @@ {% for project in data.projects %}
-
+

- {{project.acronym}} {% if project.title %}- {{project.title}}{% endif %} + {{project.acronym}} + {% if project.title %}- {{project.title}}{% endif %}

    {% if project.project_web_page %}
  • Web: {{ project.project_web_page }}
  • {% endif %} -
  • Publications: {{ project.publications|length }}
  • - +
  • + Publications: {{ project.publications|length }} +
- Details + Details »
{% empty %}

No results

{% endfor %} - - - From a4e002f76293255df0334383c0f752092ebdd8e0 Mon Sep 17 00:00:00 2001 From: Jacek Lebioda Date: Thu, 6 Feb 2020 11:11:47 +0100 Subject: [PATCH 02/21] feat: more compact editor forms - hiding the block --- web/templates/_includes/search_form.html | 4 ++-- web/templates/cohorts/cohort_form.html | 4 ++-- web/templates/cohorts/cohort_form_edit.html | 7 ++++--- web/templates/contacts/contact_form.html | 4 ++-- web/templates/contacts/contact_form_edit.html | 7 ++++--- web/templates/contracts/contract_form.html | 4 ++-- .../contracts/contract_form_edit.html | 7 ++++--- web/templates/datasets/dataset_form.html | 4 ++-- web/templates/datasets/dataset_form_edit.html | 7 ++++--- web/templates/datasets/dataset_list.html | 3 --- web/templates/partners/partner_form.html | 4 ++-- web/templates/partners/partner_form_edit.html | 7 ++++--- web/templates/projects/project_form.html | 2 +- web/templates/projects/project_form_edit.html | 7 ++++--- .../publications/publication_form.html | 4 ++-- .../publications/publication_form_edit.html | 5 +++-- web/templates/search/search_page.html | 20 ++++++++++--------- 17 files changed, 53 insertions(+), 47 deletions(-) diff --git a/web/templates/_includes/search_form.html b/web/templates/_includes/search_form.html index 23e4106b..4cb721cd 100644 --- a/web/templates/_includes/search_form.html +++ b/web/templates/_includes/search_form.html @@ -2,7 +2,7 @@

Search {{title}}

-
+
@@ -22,4 +22,4 @@

Search {{title}}

{% endif %} -
\ No newline at end of file +
diff --git a/web/templates/cohorts/cohort_form.html b/web/templates/cohorts/cohort_form.html index a7fdd9d4..07175cc2 100644 --- a/web/templates/cohorts/cohort_form.html +++ b/web/templates/cohorts/cohort_form.html @@ -3,7 +3,7 @@ {% block title %}Cohort - Add{% endblock %} {% block content %} -
+

{% block content_title %}Cohort{% endblock %}

@@ -14,4 +14,4 @@

{% block card_title %}Add cohort{% endblock %}

-{% endblock %} \ No newline at end of file +{% endblock %} diff --git a/web/templates/cohorts/cohort_form_edit.html b/web/templates/cohorts/cohort_form_edit.html index 284c99be..0a3eb0e3 100644 --- a/web/templates/cohorts/cohort_form_edit.html +++ b/web/templates/cohorts/cohort_form_edit.html @@ -1,5 +1,6 @@ {% extends 'cohorts/cohort_form.html' %} -{% block title %}Cohort - Edit{% endblock %} -{% block card_title %}Edit cohort{% endblock %} -{% block content_title %}Cohort "{{ cohort.title }}"{% endblock %} \ No newline at end of file +{% block title %}{% endblock %} +{% block card_title %}Edit cohort - {{ cohort.title }}{% endblock %} +{% block jumbotron_class %}d-none{% endblock %} +{% block content_title %}Cohort {{ cohort.title }}{% endblock %} diff --git a/web/templates/contacts/contact_form.html b/web/templates/contacts/contact_form.html index c9579dd0..203d78ff 100644 --- a/web/templates/contacts/contact_form.html +++ b/web/templates/contacts/contact_form.html @@ -3,7 +3,7 @@ {% block title %}Contact - Add{% endblock %} {% block content %} -
+

{% block content_title %}Contacts{% endblock %}

@@ -17,4 +17,4 @@

{% block card_title %}Add a new contact{% endblock %}

-{% endblock %} \ No newline at end of file +{% endblock %} diff --git a/web/templates/contacts/contact_form_edit.html b/web/templates/contacts/contact_form_edit.html index 46d7e8ff..197141db 100644 --- a/web/templates/contacts/contact_form_edit.html +++ b/web/templates/contacts/contact_form_edit.html @@ -1,5 +1,6 @@ {% extends 'contacts/contact_form.html' %} -{% block title %}Contact - Edit - {{ contact.full_name }}{% endblock %} -{% block card_title %}Edit contact{% endblock %} -{% block content_title %}{{ contact.full_name }}{% endblock %} \ No newline at end of file +{% block title %}{% endblock %} +{% block jumbotron_class %}d-none{% endblock %} +{% block card_title %}Edit contact - {{ contact.full_name }}{% endblock %} +{% block content_title %}{{ contact.full_name }}{% endblock %} diff --git a/web/templates/contracts/contract_form.html b/web/templates/contracts/contract_form.html index 7170f56a..962534e4 100644 --- a/web/templates/contracts/contract_form.html +++ b/web/templates/contracts/contract_form.html @@ -3,7 +3,7 @@ {% block title %}Contract - Add{% endblock %} {% block content %} -
+

{% block content_title %}Contracts{% endblock %}

@@ -14,4 +14,4 @@

{% block card_title %}Add contract{% endblock %}

-{% endblock %} \ No newline at end of file +{% endblock %} diff --git a/web/templates/contracts/contract_form_edit.html b/web/templates/contracts/contract_form_edit.html index 232045c2..94b3a3d4 100644 --- a/web/templates/contracts/contract_form_edit.html +++ b/web/templates/contracts/contract_form_edit.html @@ -1,5 +1,6 @@ {% extends 'contracts/contract_form.html' %} -{% block title %}Contract - Edit{% endblock %} -{% block card_title %}Edit contract{% endblock %} -{% block content_title %}{{ contract }}{% endblock %} \ No newline at end of file +{% block title %}{% endblock %} +{% block jumbotron_class %}d-none{% endblock %} +{% block card_title %}Edit - {{ contract }}{% endblock %} +{% block content_title %}{{ contract }}{% endblock %} diff --git a/web/templates/datasets/dataset_form.html b/web/templates/datasets/dataset_form.html index fe163f6a..340207bd 100644 --- a/web/templates/datasets/dataset_form.html +++ b/web/templates/datasets/dataset_form.html @@ -3,7 +3,7 @@ {% block title %}Dataset - Add{% endblock %} {% block content %} -
+

{% block content_title %}Datasets{% endblock %}

@@ -16,4 +16,4 @@

{% block card_title %}Add dataset{% endblock %}

-{% endblock %} \ No newline at end of file +{% endblock %} diff --git a/web/templates/datasets/dataset_form_edit.html b/web/templates/datasets/dataset_form_edit.html index ccb33e2b..a07f73d3 100644 --- a/web/templates/datasets/dataset_form_edit.html +++ b/web/templates/datasets/dataset_form_edit.html @@ -1,5 +1,6 @@ {% extends 'datasets/dataset_form.html' %} -{% block title %}Dataset - Edit - {{ dataset.title }}{% endblock %} -{% block card_title %}Edit dataset - {{ dataset.title }}{% endblock %} -{% block content_title %}{{ dataset.title }}{% endblock %} \ No newline at end of file +{% block title %}{% endblock %} +{% block jumbotron_class %}d-none{% endblock %} +{% block card_title %}Edit dataset - {{ dataset.title }}{% endblock %} +{% block content_title %}{{ dataset.title }}{% endblock %} diff --git a/web/templates/datasets/dataset_list.html b/web/templates/datasets/dataset_list.html index b5fcdd7d..b8187750 100644 --- a/web/templates/datasets/dataset_list.html +++ b/web/templates/datasets/dataset_list.html @@ -25,6 +25,3 @@

{{ dataset.title }}

{% empty %}

No results

{% endfor %} - - - diff --git a/web/templates/partners/partner_form.html b/web/templates/partners/partner_form.html index 97684cd0..f9ea350b 100644 --- a/web/templates/partners/partner_form.html +++ b/web/templates/partners/partner_form.html @@ -3,7 +3,7 @@ {% block title %}Partners - Add{% endblock %} {% block content %} -
+

{% block content_title %}Partners{% endblock %}

@@ -16,4 +16,4 @@

{% block card_title %}Add a new partner{% endblock %}

-{% endblock %} \ No newline at end of file +{% endblock %} diff --git a/web/templates/partners/partner_form_edit.html b/web/templates/partners/partner_form_edit.html index 78729611..eecc435e 100644 --- a/web/templates/partners/partner_form_edit.html +++ b/web/templates/partners/partner_form_edit.html @@ -1,5 +1,6 @@ {% extends 'partners/partner_form.html' %} -{% block title %}Partner - Edit{% endblock %} -{% block card_title %}Edit partner{% endblock %} -{% block content_title %}Partner "{{ partner.name }}"{% endblock %} \ No newline at end of file +{% block title %}{% endblock %} +{% block card_title %}Edit partner - {{ partner.name }}{% endblock %} +{% block jumbotron_class %}d-none{% endblock %} +{% block content_title %}Partner{% endblock %} diff --git a/web/templates/projects/project_form.html b/web/templates/projects/project_form.html index 64e95d46..9e5e3575 100644 --- a/web/templates/projects/project_form.html +++ b/web/templates/projects/project_form.html @@ -4,7 +4,7 @@ {% block title %}Project - Add{% endblock %} {% block content %} -
+

{% block content_title %}Projects{% endblock %}

diff --git a/web/templates/projects/project_form_edit.html b/web/templates/projects/project_form_edit.html index dab6f251..e761794f 100644 --- a/web/templates/projects/project_form_edit.html +++ b/web/templates/projects/project_form_edit.html @@ -1,5 +1,6 @@ {% extends 'projects/project_form.html' %} -{% block title %}Project - Edit - {{ project.acronym }}{% endblock %} -{% block card_title %}Edit project{% endblock %} -{% block content_title %}{{ project.acronym }}{% endblock %} \ No newline at end of file +{% block title %}{% endblock %} +{% block jumbotron_class %}d-none{% endblock %} +{% block card_title %}Edit project - {{ project.acronym }}{% endblock %} +{% block content_title %}{{ project.acronym }}{% endblock %} diff --git a/web/templates/publications/publication_form.html b/web/templates/publications/publication_form.html index de693c98..8ccf8052 100644 --- a/web/templates/publications/publication_form.html +++ b/web/templates/publications/publication_form.html @@ -3,7 +3,7 @@ {% block title %}Publication - Add{% endblock %} {% block content %} -
+

{% block content_title %}Publications{% endblock %}

@@ -16,4 +16,4 @@

{% block card_title %}Add a new publication{% endblock %}

-{% endblock %} \ No newline at end of file +{% endblock %} diff --git a/web/templates/publications/publication_form_edit.html b/web/templates/publications/publication_form_edit.html index c74d722e..e39aba9b 100644 --- a/web/templates/publications/publication_form_edit.html +++ b/web/templates/publications/publication_form_edit.html @@ -1,5 +1,6 @@ {% extends 'publications/publication_form.html' %} -{% block title %}Publication - Edit - {{ publication.citation }}{% endblock %} +{% block title %}{% endblock %} +{% block jumbotron_class %}d-none{% endblock %} {% block card_title %}Edit publication{% endblock %} -{% block content_title %}{{ publication.citation }}{% endblock %} \ No newline at end of file +{% block content_title %}{{ publication.citation }}{% endblock %} diff --git a/web/templates/search/search_page.html b/web/templates/search/search_page.html index 61f088c9..8e9da4e6 100644 --- a/web/templates/search/search_page.html +++ b/web/templates/search/search_page.html @@ -4,29 +4,31 @@ {% block containerclass %}container-fluid{% endblock %} - {% block content %}
-

{{ title }}

+

info {{ title }}

{{ help_text }}

Use the categories on the left or the search box below to locate {{ title }}.

-
- -