Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move interceptor behaviour to its own client/server #284

Closed
wingyplus opened this issue Nov 10, 2022 · 0 comments · Fixed by #289
Closed

Move interceptor behaviour to its own client/server #284

wingyplus opened this issue Nov 10, 2022 · 0 comments · Fixed by #289

Comments

@wingyplus
Copy link
Contributor

Currently, the interceptor behavior is defined under the GPRC namespace:

GRPC.ClientInterceptor
GRPC.ServerInterceptor

It seems that it's not consistent with adapter behavior that uses GRPC.Client.Adapter or GRPC.Server.Adapter.

So I would like purpose to move interceptor behavior to under the client/server side. So it would become:

GRPC.Client.Interceptor
GRPC.Server.Interceptor

And the implementation of the interceptor, such as logger, would move into grpc/[client|server]/interceptors as adapters do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant