Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{:datetime, :second} dtype support #885

Closed
LostKobrakai opened this issue Mar 21, 2024 · 2 comments
Closed

{:datetime, :second} dtype support #885

LostKobrakai opened this issue Mar 21, 2024 · 2 comments

Comments

@LostKobrakai
Copy link

Looking at the initial PR for the precision on datetimes I didn't find seconds as a unit being discussed. I'm dealing with a lit of unix timestamps and doing {:datetime, :millisecond} feels wrong given I initially don't have that much precision. Are there any reasons not to support second precision?

@josevalim
Copy link
Member

If it is supported in polars, I believe we can totally support it here too.

@LostKobrakai
Copy link
Author

Ah, that's where the limitation is. It only supports the 3 precisions we have it seems. I was looking at the arrow docs, which were linked on #867 and it showed second as a unit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants