Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Separate "tes_uri" from random keys in "access_uris" in Response #55

Open
soumyadipDe opened this issue Nov 19, 2019 · 0 comments
Open
Labels
priority: high High priority type flag: breaking change Proposed change breaks current API type: maintenance Related to general repository maintenance workload: hours Likely takes hours to resolve

Comments

@soumyadipDe
Copy link

Describe the bug
Currently Testribute response is returning Response where the expected "tes_uri" is clubbed with random user input keys like "a001","a002" so on. This needs to be separated and user inputs should be with "user_input" as key in separate JSON below.

Expected behavior

{
  "service_combinations": [
    { 
      "access_uris": {
        "user_input": {
          "a001": "ftp://ftp.ensembl.org/pub/release-96/fasta/homo_sapiens/dna//Homo_sapiens.GRCh38.dna.chromosome.19.fa.gz",
          "a002": "ftp://ftp.ensembl.org/pub/release-81/bed/ensembl-compara/11_teleost_fish.gerp_constrained_elements/gerp_constrained_elements.tetraodon_nigroviridis.bed.gz"
        },
        "tes_uri": "http://193.166.24.111/ga4gh/tes/v1/"
      },
      "cost_estimate": {
        "amount": 294727.1443451331,
        "currency": "EUR"
      },
      "rank": 1,
      "time_estimate": 2514
    },
    {
      "access_uris": {
        "user_input": {
          "a001": "ftp://ftp.ensembl.org/pub/release-96/fasta/homo_sapiens/dna//Homo_sapiens.GRCh38.dna.chromosome.19.fa.gz",
          "a002": "ftp://ftp.ensembl.org/pub/release-81/bed/ensembl-compara/11_teleost_fish.gerp_constrained_elements/gerp_constrained_elements.tetraodon_nigroviridis.bed.gz"
         },
        "tes_uri": "http://131.152.229.70/ga4gh/tes/v1/"
      },
      "cost_estimate": {
        "amount": 294697.1938522269,
        "currency": "EUR"
      },
      "rank": 2,
      "time_estimate": 3298
    }
  ],
  "warnings": []
}
@uniqueg uniqueg added priority: high High priority type flag: breaking change Proposed change breaks current API type: feature New feature or request workload: hours Likely takes hours to resolve type: maintenance Related to general repository maintenance and removed type: feature New feature or request labels Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: high High priority type flag: breaking change Proposed change breaks current API type: maintenance Related to general repository maintenance workload: hours Likely takes hours to resolve
Projects
None yet
Development

No branches or pull requests

2 participants