{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":579822107,"defaultBranch":"main","name":"cpython","ownerLogin":"eli-schwartz","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-12-19T02:27:00.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6551424?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1712874495.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"2bc50c4b7b5aefa3e364a563cdb7d6dc84015f6a","ref":"refs/heads/bashism","pushedAt":"2024-04-11T22:28:15.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"eli-schwartz","name":"Eli Schwartz","path":"/eli-schwartz","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6551424?s=80&v=4"},"commit":{"message":"gh-117787: configure: fix bashisms/semantic breakage of iOS checks\n\nIn commit bee7bb3310b356e99e3a0f75f23efbc97f1b0a24, support was added\nfor iOS. Although many string comparisons were added to configure.ac,\none of them used some code only valid in GNU bash.\n\nBash provides the standard `test XXX = YYY` or `[ XXX = YYY ]`\nutilities. It also provides the ability to spell the equals sign as a\ndouble equals. This does nothing whatsoever -- it adds no new\nfunctionality to bash, it forbids nothing, it is literally an exact\nalias.\n\nIt should never be used under any circumstances. Honestly, bash itself\nshould really drop support for it. Certainly, all developers must\nimmediately forget that it exists. Using it is non-portable and does not\nwork in /bin/sh scripts such as configure scripts, and it results in\ndangerous muscle memory when used in bash scripts because it makes\npeople unthinkingly use the double equals even in /bin/sh scripts. To\nadd insult to injury, it makes scripts take up more disk space (by a\nwhole byte! and sometimes even a few bytes... ;) ;))\n\nAnyway, in terms of practical difference, this results in:\n\nPOSIX sh systems such as:\n- macOS if /private/var/select/sh is tweaked\n- Linux if /bin/sh is dash and the unofficial cctools-port toolchain is\n  used\n\nalways reporting that ac_sys_system is NOT iOS, and\nnever adding the python framework to MODULE_DEPS_SHARED, even when the\nrest of the CPython build is configured for iOS.\n\nIt also reports a bad status message in the output of ./configure, which\nI caught via Gentoo's QA framework:\n\n * QA Notice: Abnormal configure code\n *\n * ./configure: 24692: test: Linux: unexpected operator","shortMessageHtmlLink":"<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2238714467\" data-permission-text=\"Title is private\" data-url=\"https://github.com/python/cpython/issues/117787\" data-hovercard-type=\"issue\" data-hovercard-url=\"/python/cpython/issues/117787/hovercard\" href=\"https://github.com/python/cpython/issues/117787\">pythongh-117787</a>: configure: fix bashisms/semantic breakage of iOS checks"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNC0xMVQyMjoyODoxNS4wMDAwMDBazwAAAAQujvAB","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNC0xMVQyMjoyODoxNS4wMDAwMDBazwAAAAQujvAB"}},"title":"Activity · eli-schwartz/cpython"}