Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACF Widget fields not rendering in Elementor #2059

Closed
enkota opened this issue Jul 23, 2017 · 15 comments
Closed

ACF Widget fields not rendering in Elementor #2059

enkota opened this issue Jul 23, 2017 · 15 comments
Labels
compatibility/3rd-party Indicates a compatibility problem with a 3rd-party plugin or theme.

Comments

@enkota
Copy link

enkota commented Jul 23, 2017

Not sure if this is already known but currently ACF Widget fields will not render within Elementor, they output within the standard WP widget area however. Are there plans to support this?

Thanks!

@arielk
Copy link
Member

arielk commented Jul 28, 2017

Can you explain please what is mean ACF widget, plugin?

@enkota
Copy link
Author

enkota commented Jul 28, 2017

@arielk Apologies, so I am displaying ACF fields in a normal WP widget I've created. When adding this widget via the elementor editor, the ACF fields will not display.

Default widget page
screen shot 2017-07-28 at 19 23 23

Elementor editor
screen shot 2017-07-28 at 19 24 12

@arielk
Copy link
Member

arielk commented Jul 30, 2017

Can you please share with us the code of your widget?

@arielk arielk added the question* [DEPRECATED] Indicates when an issue is used to ask a Question. label Jul 30, 2017
@enkota
Copy link
Author

enkota commented Jul 30, 2017

Sure could do, but just done some further testing.

  1. Create new text field in ACF that will display in the default WP text widget.

screen shot 2017-07-30 at 09 23 43

  1. Go to widget area to check it appears.

screen shot 2017-07-30 at 09 23 11

  1. Go to Elementor editor and drag in the WP text widget. No field appears. I believe it could be related to how ACF render fields outside the widget area.

screen shot 2017-07-30 at 09 24 10

@arielk arielk added compatibility/3rd-party Indicates a compatibility problem with a 3rd-party plugin or theme. and removed question* [DEPRECATED] Indicates when an issue is used to ask a Question. labels Jul 30, 2017
@nicooprat
Copy link

Can confirm it doesn't work. Using Wordpress 4.8, ACF Pro 5.6 and Elementor 1.5.5. No error in PHP or JS console. ACF compatibility would be the killer feature! I'd like to use it to create custom components in a easy way (instead of creating them using Elementor API).

@MaskaZan
Copy link

MaskaZan commented Aug 8, 2017

@nicooprat +1

1 similar comment
@NailKhalimov
Copy link

@nicooprat +1

@Shomme
Copy link

Shomme commented Aug 8, 2017

@nicooprat ++ acf+elementor for the win

@enkota
Copy link
Author

enkota commented Aug 21, 2017

hey @arielk should we maybe merge with this ticket to consolidate ideas about custom fields rendering in widgets? - #1071

@arielk
Copy link
Member

arielk commented Aug 22, 2017

@enkota I think it’s a bit differentת this issue relates to compatibility with ACF, in order to build a new widget for Elementor under WordPress widgets, but the other issue is for adding a custom field into existing widgets.

@enkota
Copy link
Author

enkota commented Aug 22, 2017

@arielk I see! Okay no worries, keep us updated if you need any further testing with ACF. Thanks!

@ffoodd
Copy link

ffoodd commented Feb 8, 2018

FWIW I managed to show ACF fields in Elementor by adding:

do_action_ref_array( 'in_widget_form', array( &$instance, null, $this->get_settings( 'wp' )  ) );

right after $instance->form() in:
https://github.com/pojome/elementor/blob/67ddcf242e675b328f1bdd9b3cd0c2f83720c76e/includes/widgets/wordpress.php#L145

Doesn't work for any reason, ACF scripts aren't loaded I think but I don't have time to search anymore.

Hope it'll help someway.

@JeanDavidDaviet
Copy link

Hello everyone, does version 2 solves this problem ? I would love to use Elementor, but I can't until I'm sure ACF Pro is supported.
Thanks !

@bainternet
Copy link
Contributor

In Elementor Pro v2 we added partial support for ACF integration, as for ACF WordPress native widget, it's not something we can change or update, it has to come from the 3rd party plugin author.

thanks for the suggestions.

@imadeel96
Copy link

FWIW I managed to show ACF fields in Elementor by adding:

do_action_ref_array( 'in_widget_form', array( &$instance, null, $this->get_settings( 'wp' )  ) );

right after $instance->form() in: https://github.com/pojome/elementor/blob/67ddcf242e675b328f1bdd9b3cd0c2f83720c76e/includes/widgets/wordpress.php#L145

Doesn't work for any reason, ACF scripts aren't loaded I think but I don't have time to search anymore.

Hope it'll help someway.

Where to add that do_action_ref_array code in WordPress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility/3rd-party Indicates a compatibility problem with a 3rd-party plugin or theme.
Projects
None yet
Development

No branches or pull requests

10 participants