Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal: Remove support for experimental msc3886 #17638

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Removal: Remove support for experimental msc3886 #17638

wants to merge 2 commits into from

Conversation

rahulporuri
Copy link

@rahulporuri rahulporuri commented Aug 30, 2024 •
edited
Loading

fixes #17619

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@rahulporuri rahulporuri requested a review from a team as a code owner August 30, 2024 13:44
@rahulporuri rahulporuri mentioned this pull request Aug 30, 2024
Open
anoadragon453
anoadragon453 requested changes Sep 6, 2024
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM on the whole, thank you!

Lastly I didn't mention this in my original comment. But despite this being an experimental feature, I think we should put a paragraph in the upgrade notes letting sysadmins know that this option is going away. The upgrade notes are typically where we warn of breaking changes.

So something like:

# Upgrading to v1.115.0

## Removal of experimental MSC3886 feature

[MSC3886](https://github.com/matrix-org/matrix-spec-proposals/pull/3886) has been closed (and will not enter the Matrix spec). As such, we are removing the experimental support for it from Synapse in this release.

The `experimental_features.msc3886_endpoint` configuration option has been removed.

changelog.d/17638.removal
@@ -0,0 +1 @@
Remove support for closed MSC3886.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Remove support for closed MSC3886.
Remove support for closed [MSC3886](https://github.com/matrix-org/matrix-spec-proposals/pull/3886).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for MSC3886 no longer needs to be maintained
2 participants
@rahulporuri @anoadragon453