Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable opentracing in _handle_new_device_update_async #12559

Open
matrixbot opened this issue Dec 19, 2023 · 0 comments
Open

Reenable opentracing in _handle_new_device_update_async #12559

matrixbot opened this issue Dec 19, 2023 · 0 comments
Labels
A-Device-List-Tracking A-Logging S-Tolerable T-Defect

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 19, 2023 •
edited
Loading

This issue has been migrated from #12559.

In #12552 we encountered pain because of a log_kv call that was not correctly associated with an opentracing span.

#12554 avoided the pain by commenting out the call to log_kv.

It's still useful to have this data available for debugging. We should fix this so that we are able to log_kv once more. matrix-org/synapse#12552 (comment) describes two possible ways to do so. The error mentioned in its last paragraph has been fixed by matrix-org/synapse#12555.
@matrixbot matrixbot changed the title Dummy issue Reenable opentracing in _handle_new_device_update_async Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Device-List-Tracking A-Logging S-Tolerable T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matrixbot