Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt megolm keys securely in indexeddb #8938

Closed
ara4n opened this issue Feb 25, 2019 · 2 comments
Closed

Encrypt megolm keys securely in indexeddb #8938

ara4n opened this issue Feb 25, 2019 · 2 comments

Comments

@ara4n
Copy link
Member

ara4n commented Feb 25, 2019

Currently we encrypt megolm keys with a hardcoded key of DEFAULT_KEY, as per https://github.com/matrix-org/matrix-js-sdk/blob/master/src/crypto/OlmDevice.js#L77

Instead we should do something like https://crypto.stackexchange.com/a/52488 to generate a secure keypair, and store it in Indexed DB with the .extractable property set to false.

@bwindels
Copy link
Contributor

bwindels commented Mar 4, 2019

wrt the linked ticket, as the CryptoKey would also be stored in the network home directory (within indexeddb), wouldn't that still allow the admin to run Riot off that directory and decrypt the messages?

@uhoreg
Copy link
Member

uhoreg commented Jan 15, 2020

Closing in favour of #7271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants