Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut/paste of pill mention #4902

Closed
turt2live opened this issue Aug 27, 2017 · 3 comments
Closed

Cut/paste of pill mention #4902

turt2live opened this issue Aug 27, 2017 · 3 comments
Labels
P3 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@turt2live
Copy link
Member

Typing a message to someone, then ctrl+a, cut, paste of the message should also keep the pill

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Aug 30, 2017

We only paste text in markdown mode. We could at the copied HTML and convert it to MD but this would require implementing our own HTML to MD converter (the commonmark library obviously only supports MD to HTML). Of course, we could fix the RTE in general by not supporting RT 😇 (draft-js does not support swapping between two different representations natively) (see #4679 for crazy diagram).

@lampholder lampholder added S-Minor Impairs non-critical functionality or suitable workarounds exist P3 ui/ux T-Defect labels Sep 5, 2017
@lampholder
Copy link
Member

I've made this a P3 because sadly it is (I believe) a lot of effort for a relatively small gain.

Not being able to cut and then paste a pill-containing message in the composer is surprising, and therefore bad. If we can fix this we should, but we shouldn't at this stage invest weeks of effort to resolve this issue :(

@turt2live
Copy link
Member Author

Fixed by some magic in the last year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants