-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme Options in User Settings Are Mildly Broken #4700
Comments
Confirmed also broken on riot.im/develop |
This is only a minor glitch in everyday use, but becomes more problematic when >2 theme options are included under User Settings. |
When trying to reproduce this, I had a slightly different failure mode. I had Riot logged in on two machines (side by side). Toggling from light to dark on machine A, the change actually occurred on machine B. Machine A did not change it's theme. Toggling from dark back to light as described in the original report had no effect. |
note to self, onChange is only firing the first time |
was fine in v0.10.2 |
It seems like it was broken by an unpinned React dep |
React 15.6.0 introduced facebook/react#8575 which broke the theme selector |
This has been fixed. |
Description
After switching between theme options using the radio buttons in User Settings, switching back to the previous selection has no effect.
Steps to reproduce
The theme will remain Dark.
If you close the User Settings window and reopen, you are then able to select the radio button for the theme of your choice.
Log: sent
Version information
For the web app:
The text was updated successfully, but these errors were encountered: