Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App displays a background for custom emotes when it should be transparent #27745

Closed
Koakuma-spec opened this issue Jul 15, 2024 · 4 comments · Fixed by matrix-org/matrix-react-sdk#12798
Labels
A-Emotes O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs

Comments

@Koakuma-spec
Copy link

Steps to reproduce

  1. Type in custom emotes using /html. Here is one example: /html <img src="mxc://midov.pl/eef5810eddf6b07d412d44ab9771e46ce774f188" width="32">
  2. Send it
  3. Hover over it - whether you're using a light or a dark theme, it is there. It is ESPECIALLY visible when the user is using a custom theme.

Additional note: I think this "bug fix" may have been responsible for it.
Additional note 2: Because to temporarily fix this, I have to go into DevTools and manually uncheck the background color box under .markdown-body img. I also did not see this background in previous versions of element.
image

Outcome

What did you expect?

image

What happened instead?

image

Operating system

Windows

Application version

Element version: 1.11.70 Crypto version: Rust SDK 0.7.1 (80a151e), Vodozemac 0.6.0

How did you install the app?

https://element.io/get-started

Homeserver

No response

Will you send logs?

No

@dosubot dosubot bot added A-Themes-Custom Custom theme variables or support O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jul 15, 2024
@t3chguy
Copy link
Member

t3chguy commented Jul 15, 2024

Additional note: I think this "matrix-org/matrix-react-sdk#12628" may have been responsible for it.

Doesn't look like it, your screenshot shows that it comes from https://github.com/sindresorhus/github-markdown-css

@t3chguy t3chguy added A-Emotes and removed A-Themes-Custom Custom theme variables or support labels Jul 15, 2024
@Koakuma-spec
Copy link
Author

ahh, so that updated by adding a background to the css which is why i see one behind my emotes?

@t3chguy t3chguy transferred this issue from element-hq/element-desktop Jul 15, 2024
@dosubot dosubot bot added A-Themes-Custom Custom theme variables or support O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jul 15, 2024
@t3chguy t3chguy removed A-Themes-Custom Custom theme variables or support O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jul 15, 2024
@github-actions github-actions bot removed the Z-Labs label Jul 15, 2024
@t3chguy t3chguy added the Z-Labs label Jul 15, 2024
@asimdelvi
Copy link

Can you assign me this issue

@t3chguy
Copy link
Member

t3chguy commented Jul 16, 2024

Thank you for your interest in this issue. We will normally not assign the issue to an external contributor until they have provided at least a draft PR which is taking the right direction. For further details, see our guidance on assigning issues.

If you have any technical questions about this issue, you can ask for help in #element-dev:matrix.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Emotes O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants