Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing reactions in room (main timeline) #25630

Closed
MadLittleMods opened this issue Jun 19, 2023 · 3 comments
Closed

Missing reactions in room (main timeline) #25630

MadLittleMods opened this issue Jun 19, 2023 · 3 comments

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Jun 19, 2023

Steps to reproduce

  1. Notice missing reactions on a message
  2. Reproduced on Element Web and other Element Desktop clients
  3. Consistent after update/refresh and switching rooms

Outcome

What did you expect?

All reactions should be visible

What happened instead?

No reactions show up on the message and the reaction events don't even show up as hidden events in the timeline

All of the missing reactions correspond to these rageshake log entries which indicate the events are seen by the client but being mistakenly ignored in the main timeline (details in the rageshake)

EventTimelineSet.addEventToTimeline: Ignoring event=$abc that does not belong in timeline=!foo:2023-06-19T22:17:22.759Z timelineSet(threadId=undefined)

Probably related to:

Operating system

Manjaro Linux (Arch-based)

Browser information

Chrome Version 114.0.5735.133

URL for webapp

https://develop.element.io/

Application version

Element version: 0417473-react-a491795aa7ed-js-80cdbe1058c1 Olm version: 3.2.14

Homeserver

matrix.org

Will you send logs?

Yes -> https://github.com/matrix-org/element-web-rageshakes/issues/21918, https://github.com/matrix-org/element-web-rageshakes/issues/21931

@weeman1337
Copy link
Contributor

Thank you for your report.

It seems you're not the only one to have come across this bug, as it's been reported previously. I'm going to close this issue now so we can focus on the older issue. Please watch, vote or comment on that issue if there is any additional information you can provide.

@weeman1337
Copy link
Contributor

Duplicate of #25596

@weeman1337 weeman1337 marked this as a duplicate of #25596 Jun 20, 2023
@weeman1337 weeman1337 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2023
@MadLittleMods
Copy link
Contributor Author

Another set of debug logs with the extra info from matrix-org/matrix-js-sdk#3494 -> https://github.com/matrix-org/element-web-rageshakes/issues/21931

Here are the logs around one missing reaction on the original message: $p_giIbORbdY2Mk0f6mSFZOAfcG24eqIDsG-8PT7_E7E

2023-06-20T17:42:26.548Z D Room::eventShouldLiveIn: eventId=$p_giIbORbdY2Mk0f6mSFZOAfcG24eqIDsG-8PT7_E7E parentEventId=$nH4JpeIhEuiY9ets2cgYn4IvsyQ_feCfZj-6MVP81YE found=true

2023-06-20T17:42:26.550Z D Room::eventShouldLiveIn: eventId=$p_giIbORbdY2Mk0f6mSFZOAfcG24eqIDsG-8PT7_E7E parentEventId=$nH4JpeIhEuiY9ets2cgYn4IvsyQ_feCfZj-6MVP81YE found=false
2023-06-20T17:42:26.550Z D Room::eventShouldLiveIn: eventId=$p_giIbORbdY2Mk0f6mSFZOAfcG24eqIDsG-8PT7_E7E belongs to an unknown timeline
2023-06-20T17:42:26.550Z W EventTimelineSet.addEventToTimeline: Ignoring event=$p_giIbORbdY2Mk0f6mSFZOAfcG24eqIDsG-8PT7_E7E that does not belong in timeline=!QKLszEbjJygAduTMZK:librepush.net:2023-06-20T17:40:23.927Z timelineSet(threadId=undefined)

Here is a missing reaction on the edited message: $NccBSsH59-FnLgOiALNk6sY4pPhUyUnHyrIg3UlvNNo

2023-06-20T17:40:40.014Z D Room::eventShouldLiveIn: eventId=$NccBSsH59-FnLgOiALNk6sY4pPhUyUnHyrIg3UlvNNo parentEventId=$nH4JpeIhEuiY9ets2cgYn4IvsyQ_feCfZj-6MVP81YE found=true
2023-06-20T17:40:40.014Z D Room::eventShouldLiveIn: eventId=$nH4JpeIhEuiY9ets2cgYn4IvsyQ_feCfZj-6MVP81YE not a relation
2023-06-20T17:40:40.014Z D Room::eventShouldLiveIn: eventId=$NccBSsH59-FnLgOiALNk6sY4pPhUyUnHyrIg3UlvNNo parentEventId=$nH4JpeIhEuiY9ets2cgYn4IvsyQ_feCfZj-6MVP81YE found=false
2023-06-20T17:40:40.014Z D Room::eventShouldLiveIn: eventId=$NccBSsH59-FnLgOiALNk6sY4pPhUyUnHyrIg3UlvNNo belongs to an unknown timeline
2023-06-20T17:40:40.014Z W EventTimelineSet.addEventToTimeline: Ignoring event=$NccBSsH59-FnLgOiALNk6sY4pPhUyUnHyrIg3UlvNNo that does not belong in timeline=!QKLszEbjJygAduTMZK:librepush.net:2023-06-20T17:40:23.927Z timelineSet(threadId=undefined)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants