Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element-R: Handle incoming verification requests #25320

Closed
2 tasks done
Tracked by #24979
richvdh opened this issue May 9, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11169
Closed
2 tasks done
Tracked by #24979

Element-R: Handle incoming verification requests #25320

richvdh opened this issue May 9, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11169
Assignees
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Task Tasks for the team like planning

Comments

@richvdh
Copy link
Member

richvdh commented May 9, 2023

Build on outgoing verification (#24983, #25316, #25319).

  • Define a new cypress test. Flow should be:

    • Create a “bot” account with bootstrapped cross signing
    • Log into the same account
    • Dismiss the “verify this device” dialog
    • From the bot device, call MatrixClient.requestVerification
    • Go through the verification process.
    • At the end, download the device keys and check that it is cross-signed.

    Estimate: 1d
    Cypress test for incoming verification requests matrix-org/matrix-react-sdk#11123

  • Implement in RustCrypto. We need to:

    • Monitor for incoming m.key.verification.request messages
    • Call OlmMachine::get_verification_request and convert to a VerificationRequest as above
    • Tell MatrixClient to emit a CryptoEvent.VerificationRequest.
      • Possibly this means having RustCrypto extend TypedEventEmitter, and making MatrixClient reemit.
    • js-sdk integration test: extend the one added earlier

    Estimate: 1d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant