Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic pill-ification picks up IRC logins as user IDs #24804

Closed
turt2live opened this issue Mar 12, 2023 · 6 comments
Closed

Automatic pill-ification picks up IRC logins as user IDs #24804

turt2live opened this issue Mar 12, 2023 · 6 comments
Assignees
Labels
A-Pills O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@turt2live
Copy link
Member

Steps to reproduce

  1. Send a message similar to the one below.

Outcome

What did you expect?

No pill

What happened instead?

image

on this message:

{
  "body": "Last login from: ~travisr@2001:470:69fc:105::f on Mar 12 04:06:44 2023 +0000.",
  "format": "org.matrix.custom.html",
  "formatted_body": "Last login from: <b>~travisr@2001:470:69fc:105::f</b> on Mar 12 04:06:44 2023 +0000.",
  "msgtype": "m.notice"
}

Operating system

Windows 10

Application version

Element Nightly version: 0.0.1-nightly.2023031001 Olm version: 3.2.12

How did you install the app?

The Internet

Homeserver

t2l.io

Will you send logs?

No

@weeman1337 weeman1337 added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Pills O-Occasional Affects or can be seen by some users regularly or most users rarely labels Mar 13, 2023
@weeman1337
Copy link
Contributor

Tested with last stable version. This is not a regression caused by current work on pills. The issue is, that the part after @ is linkified.

@t3chguy
Copy link
Member

t3chguy commented Mar 13, 2023

This is a regression on Staging

App:
image

Staging:
image

@t3chguy
Copy link
Member

t3chguy commented Mar 13, 2023

This breaks copy-pasting due to the pill adding spurious spaces

@andybalaam
Copy link
Contributor

@weeman1337 is this a regression from earlier work?

@weeman1337
Copy link
Contributor

Turning it into a pill is caused by it being detecting a MXID in the first place.
This is already the case on app.element.io.

In my opinion the real issue is: MXID-like strings inside text should not be detected as MXIDs.

@weeman1337 weeman1337 self-assigned this Mar 13, 2023
@weeman1337
Copy link
Contributor

Closed by matrix-org/matrix-react-sdk#10370

Linkification may be a separate topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Pills O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Development

No branches or pull requests

4 participants