Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin should be removed from the widget kebab menu #22466

Closed
weeman1337 opened this issue Jun 7, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#8924
Closed

Unpin should be removed from the widget kebab menu #22466

weeman1337 opened this issue Jun 7, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#8924
Assignees
@weeman1337
Labels
A-Widgets O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Enhancement

Comments

@weeman1337
Copy link
Contributor

weeman1337 commented Jun 7, 2022 •
edited
Loading

Steps to reproduce

  1. Add a custom widget to a room
  2. Look at the actions in the widget title and the kebab menu

Outcome

What did you expect?

  • No „Unpin“ item

What happened instead?

  • Menu contains an „Unpin“ item

image

Operating system

Ubuntu 22.04 LTS

Browser information

Firefox 100.0.2 (64-bit)

URL for webapp

https://develop.element.io/

Application version

Element version: b44df4b-react-3a20cb17038b-js-2982bd79f610 Olm version: 3.2.8

Homeserver

No response

Will you send logs?

No
@weeman1337 weeman1337 mentioned this issue Jun 7, 2022
Closed
@weeman1337 weeman1337 added S-Tolerable Low/no impact on users A-Widgets O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jun 7, 2022
@HarHarLinks
Copy link
Contributor

According to #20506 (comment) the option in the kebab menu should simply have been removed, but it appears that did not in fact happen.

@weeman1337
Copy link
Contributor Author

Thanks for linking the comment @HarHarLinks

@weeman1337 weeman1337 changed the title Different labels for minimise in the widget title ↔ kebab menu Unpin should be removed from the widget kebab menu Jun 10, 2022
@weeman1337 weeman1337 self-assigned this Jun 28, 2022
@weeman1337 weeman1337 mentioned this issue Jun 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weeman1337 weeman1337

Labels
A-Widgets O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unpin from widget kebab menu matrix-org/matrix-react-sdk
2 participants
@HarHarLinks @weeman1337