Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline forward-paginates infinitely when jumping to hidden events #22123

Open
robintown opened this issue May 9, 2022 · 5 comments
Open

Timeline forward-paginates infinitely when jumping to hidden events #22123

robintown opened this issue May 9, 2022 · 5 comments
Labels
A-Timeline A-Timeline-Jumpy-Scroll Stable timeline dream ✨ O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression Z-Rageshake Has attached rageshake (not for log submission process)

Comments

@robintown
Copy link
Member

robintown commented May 9, 2022 •
edited by MadLittleMods
Loading

Steps to reproduce

  1. Copy the permalink of a hidden event somewhere in the scrollback of a room
  2. Click on that permalink

Outcome

What did you expect?

To jump to the area of the hidden event, and stay there

What happened instead?

The timeline jumps to the hidden event, and then forward-paginates infinitely as fast as possible, with scroll offset stuck to the bottom. Clicking the 'Jump to bottom' button or another permalink stops this behavior.

Rageshake attached with ScrollPanel and TimelinePanel debug logs enabled.

Operating system

NixOS unstable

Browser information

Firefox 99.0.1

URL for webapp

develop.element.io

Application version

Element version: 1783645-react-617c0e3c50c2-js-706b4d605481 Olm version: 3.2.8

Homeserver

Synapse 1.58.0

Will you send logs?

Yes
@robintown robintown added T-Defect X-Regression S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Timeline Z-Rageshake Has attached rageshake (not for log submission process) O-Uncommon Most users are unlikely to come across this or unexpected workflow labels May 9, 2022
@turt2live
Copy link
Member

also reproduced using jump-to-date, which is reportedly the same code path.

@robintown robintown changed the title Timeline forward-paginates infinitely when jumping to certain events Timeline forward-paginates infinitely when jumping to hidden events May 9, 2022
@robintown
Copy link
Member Author

Cause determined to be hidden events

@t3chguy t3chguy mentioned this issue May 12, 2022
Closed
@t3chguy
Copy link
Member

t3chguy commented May 13, 2022

Is this a duplicate of #5937? Are we sure about f vs b?

@robintown
Copy link
Member Author

I've never seen it go backwards, I think #5937 is stale

@t3chguy t3chguy mentioned this issue May 13, 2022
Closed
@t3chguy
Copy link
Member

t3chguy commented May 23, 2022

Related #19230

@turt2live turt2live mentioned this issue Aug 5, 2022
Closed
@robintown robintown added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Nov 25, 2022
@MadLittleMods MadLittleMods added the A-Timeline-Jumpy-Scroll Stable timeline dream ✨ label Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Timeline A-Timeline-Jumpy-Scroll Stable timeline dream ✨ O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression Z-Rageshake Has attached rageshake (not for log submission process)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@MadLittleMods @Johennes @turt2live @t3chguy @robintown