Disable url previews in E2E rooms by default

[ara4n]

No description provided.

[uhoreg]

In addition to disabling URL previews by default, the room setting to enable/disable URL previews should come with a warning in e2e rooms that enabling them may leak information.

[PureTryOut]

This happens in WhatsApp as well and is gaining a fair bit of attention on /r/Android. Please disable it by default, it shouldn't be that hard to do.

[t3chguy]

@ara4n given the prio bump could you clarify the desired behaviour

• Do we split the UserSettings toggle into non-e2ee and e2ee
• Do we ignore account&default values for e2ee rooms and require it to be explicitly set per-room
• something else

[turt2live]

It makes sense to me to say that the room setting means nothing in e2e rooms, likewise for account. room-account or room-device (technically not settable) would have to be explicitly required.

[t3chguy]

so the latter option but also ignoring room

[Half-Shot]

Explicitly set per room seems obvious to me PLUS making sure the user knows the implications (I realise they should know the implications as it's E2E, but I'd spell out the consequences anyway)

[t3chguy]

(I realise they should know the implications as it's E2E, but I'd spell out the consequences anyway)

This either way :)

[t3chguy]

opinion on wording? (ignore i18n warning)

[turt2live]

I'd recommend starting with explaining what they are (which should really be included in every room to be honest). How does something like this sound?

When someone puts a URL in their message, a URL preview can be shown to give more information about that link such as the title, description, and an image from the website. In encrypted rooms, like this one, URL previews are disabled by default to ensure that your homeserver (where the previews are generated) cannot gather information about links you see in this room.

[t3chguy]

i like it

many thanks @turt2live

[t3chguy]

🎉