Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spaceId from IRightPanelCardState[Stored] #20721

Closed
jryans opened this issue Jan 24, 2022 · 3 comments · Fixed by #28538
Closed

Remove spaceId from IRightPanelCardState[Stored] #20721

jryans opened this issue Jan 24, 2022 · 3 comments · Fixed by #28538
Assignees
Labels
A-Right-Panel T-Task Tasks for the team like planning

Comments

@jryans
Copy link
Collaborator

jryans commented Jan 24, 2022

It seems redundant, since the space ID is always the room ID.

@jryans jryans added T-Task Tasks for the team like planning A-Right-Panel labels Jan 24, 2022
@jryans jryans self-assigned this Jan 24, 2022
@jryans
Copy link
Collaborator Author

jryans commented Jan 24, 2022

@toger5 Any chance you remember why the spaceId field is there...? Perhaps I am missing a use case.

@toger5
Copy link
Contributor

toger5 commented Jan 24, 2022

Not really. It was part of the old reference parameters. I think it is the same debate as with the member parameter of the card state. Either we have somewhat redundant parameters. Like roomMember and verificationUser or we only have member. One is redundant but more explicit and the other one. Well is not redundant but less explicit. I think we can do the same with spaceId and roomId (use the same param (roomId for both: spaceIdand roomId). I would at least add a comment to the state interface to make clear what the value is used for (for room and space id's)

@t3chguy
Copy link
Member

t3chguy commented Nov 25, 2024

At one point you could view the member list for a space without switching to the Space home/hierarchy, so it was needed for that, nowadays SpaceMemberList can probably go away entirely and just use RoomMemberList

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Right-Panel T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants