Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from sending membership event for kick to using the /kick API #19018

Closed
3 tasks done
aaronraimist opened this issue Sep 14, 2021 · 2 comments · Fixed by matrix-org/matrix-js-sdk#1934
Closed
3 tasks done

Comments

@aaronraimist
Copy link
Collaborator

aaronraimist commented Sep 14, 2021

I created a PR to to Synapse to align Synapse's implementation of membership events with the way that the spec says they should work matrix-org/synapse#10807. The problem with that is it will reintroduce #1961 because right now when you click the kick button in MemberInfo or use the /kick slash command Element sends a membership event for that user rather than using the dedicated API https://spec.matrix.org/unstable/client-server-api/#post_matrixclientr0roomsroomidkick

So Element needs to switch over to using the /kick API so that behavior does not come back once the Synapse PR is merged.

  • Change slash command to use dedicated /kick API
  • Change MemberInfo to use dedicated /kick API
  • Investigate if there are any other areas where kicking or banning happen via membership events. The ban and unban buttons in MemberInfo, /ban and /unban slash commands, and the unban button in the room settings seem to all use the proper APIs.
@t3chguy
Copy link
Member

t3chguy commented Sep 14, 2021

I think this issue belongs on https://github.com/matrix-org/matrix-js-sdk but can't transfer cross-org

@novocaine
Copy link
Contributor

novocaine commented Sep 17, 2021

So I think the steps to test this from an Element Web perspective are

  • Check kick still works (doesn't matter where from in the UI, as we're changing the SDK implementation, not the call sites)
  • Check the above at different power-levels for the kicker and the kickee matches expected behaviour

We have reason to be cautious here because breaking kick would be Bad and we don't use this API elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants