Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display name on autocomplete dropdown wraps over the item on the line below #17923

Closed
germain-gg opened this issue Jul 9, 2021 · 3 comments
Closed

Display name on autocomplete dropdown wraps over the item on the line below #17923

germain-gg opened this issue Jul 9, 2021 · 3 comments
Assignees
@janogarcia
Labels
A-Autocomplete O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design

Comments

@germain-gg
Copy link
Contributor

germain-gg commented Jul 9, 2021 •
edited
Loading

Screen Shot 2021-07-09 at 16 52 35
@germain-gg germain-gg added P3 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Bite-Sized labels Jul 9, 2021
@SimonBrandner SimonBrandner added Help Wanted Extra attention is needed and removed Z-Bite-Sized P3 labels Aug 27, 2021
@dbkr dbkr added the O-Occasional Affects or can be seen by some users regularly or most users rarely label Jan 17, 2022
@dbkr
Copy link
Member

dbkr commented Jan 17, 2022

Should probably truncate the display name with an eliipsis at the end, but moving to x-needs-design to confirm.

@dbkr dbkr added X-Needs-Design and removed Help Wanted Extra attention is needed labels Jan 17, 2022
@janogarcia janogarcia self-assigned this Jan 31, 2022
@janogarcia
Copy link

@gsouquet What about using the same text truncation logic we defined for the Thread List?

matrix-org/matrix-react-sdk#7549 (comment)

  • The display name takes precedence. Display it as an inline block that takes up as much available space as necessary (i.e. do not set a max width for it that is less than 100% its parent container).
  • The remaining space is filled by the Matrix User ID, which will be the first to get truncated if the available space becomes limited.

Note: There's a lot of stuff that we could improve visually for those pills (sizes, spacing, typesetting...), but I'm trying to focus just on this issue's scope.

@SimonBrandner SimonBrandner mentioned this issue Mar 11, 2022
Open
@germain-gg
Copy link
Contributor Author

Closing in favour of #21393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janogarcia janogarcia

Labels
A-Autocomplete O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@janogarcia @germain-gg @dbkr @SimonBrandner