Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty right margin with read recipts disabled on IRC style layout #16803

Closed
meain opened this issue Mar 27, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#5864
Closed
Assignees
Labels
A-IRC-Layout A-Read-Receipts Help Wanted Extra attention is needed P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@meain
Copy link

meain commented Mar 27, 2021

Screenshot 2021-03-27 at 10 36 57 PM

Description

The right margin in Element desktop (on macOS) seems to retain the right edge even if read receipts are disabled in the IRC style layout. Related issue: #4248 . It seems to work fine in default mode, but does not seem to take effect when using IRC style display. This kinda make it a harder to use when the app is not able to use full width.

Version information

  • Platform: Desktop
  • OS: macOS
  • Version: Element version: 1.7.23 - olm version: 3.2.1
@meain meain added the T-Defect label Mar 27, 2021
@jryans jryans added Help Wanted Extra attention is needed P2 S-Minor Impairs non-critical functionality or suitable workarounds exist labels Mar 30, 2021
@samhh
Copy link

samhh commented Apr 10, 2021

I'm not familiar enough with that code to feel confident in making a PR that doesn't break other things, but locally it looked like changing .mx_EventTile_msgOption in the React SDK to have a max-width as opposed to a fixed width vastly improved matters. In an ideal world that JSX doesn't even get rendered if there's nothing relevant to put there, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-IRC-Layout A-Read-Receipts Help Wanted Extra attention is needed P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants