Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Remove Recent Messages dialogue more clear #16064

Closed
catscratchedme opened this issue Jan 3, 2021 · 1 comment
Closed

Make Remove Recent Messages dialogue more clear #16064

catscratchedme opened this issue Jan 3, 2021 · 1 comment
Labels
A-Moderation P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@catscratchedme
Copy link

catscratchedme commented Jan 3, 2021

Description

Using the Remove recent messages feature does not always remove messages that are visible on the screen.

Steps to reproduce

  • Go to room with many messages
  • Scroll up multiple pages, and use "Remove recent messages" on a user
  • Observe the # of messages it tells you will be removed. It's not clear to the user where this number comes from (where does it look for the first and last messages that are eligible to be removed?)
  • Copy the permalink of the oldest removed message (further up on the timeline). Let's say you become busy with something else, and can't finish redacting all the messages right now.
  • Clear cache
  • Use /goto to jump to the permalink that you copied earlier
  • Scroll up a bit to load messages for the targeted user
  • If you are too far away from the oldest message you've already redacted, the remove recent messages dialogue will tell you "No recent messages by [user] found. Try scrolling up in the timeline to see if there are any earlier ones."
  • It's not clear to me why no recent messages are found, when you can see messages by the targeted user on the screen. If you scroll up on the timeline, you will get the same dialogue, and will not be able to redact any messages

Describe how what happens differs from what you expected.

I would expect that Remove recent messages would work from newest to oldest messages. If the user's 100 most recent messages has been redacted, I would expect that it would start redacting from the 101th most recent message, even if you had the 500th most recent message on your screen.

I would expect that it would at least remove at least as many messages as are on the screen from the targeted user.

If the dialogue tells me: "Try scrolling up in the timeline to see if there are any earlier ones," I would expect that scrolling up would let the client find messages that I can redact, but in reality scrolling up doesn't achieve that.

Version information

  • Platform: desktop?
  • Version: 1.7.16

For the desktop app:

  • OS: Linux Mint
  • Version: 20
@jryans jryans added defect P2 S-Minor Impairs non-critical functionality or suitable workarounds exist A-Moderation labels Jan 22, 2021
@jryans jryans removed the defect label Mar 4, 2021
@t3chguy
Copy link
Member

t3chguy commented Jul 13, 2023

Duplicate of #10819

@t3chguy t3chguy marked this as a duplicate of #10819 Jul 13, 2023
@t3chguy t3chguy closed this as completed Jul 13, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Moderation P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants