Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (configurable) support for custom protocols/URLs / prevent element from messing with them #15018

Open
tgurr opened this issue Aug 21, 2020 · 5 comments

Comments

@tgurr
Copy link

tgurr commented Aug 21, 2020

Is your suggestion related to a problem? Please describe.

We've a document management system which generates links like e.g. vis://08680B3E-6E1E-4C1B-B3E7-7019D5FFB910/14/5079312 which element currently automatically translates to https://08680B3E-6E1E-4C1B-B3E7-7019D5FFB910/14/5079312 when sent via a chat message, which then won't work for us when clicking on it in a browser.

Describe the solution you'd like
It would be really useful if element would have support for such custom protocols/URLs. Either per se, or configurable in some way via an allow-list.

@t3chguy
Copy link
Member

t3chguy commented Aug 21, 2020

The linkification library does not support this Hypercontext/linkifyjs#194

Related #8720 #4457 #4793

@jaime-rivas
Copy link

Hello Michael!

I'm writing to follow-up for any updates on this. We have many users and would love to migrate them to Matrix & Element, but having the custom protocol links clickable is a must. Thank you!

@tgurr
Copy link
Author

tgurr commented Dec 16, 2020

Maybe linkifyjs should be replaced or forked, as clearly upstream seems to have gone stale with the initial report regarding additional protocol support being from 2017 with no response at all and git master also showing only low maintanance work since years.

@jryans
Copy link
Collaborator

jryans commented Jan 11, 2021

It seems like a good thing to support. At the moment, we'd need have a better understanding of how many people are impacted by this, or else wait for someone to contribute a change / sponsor the core team to make a change.

@natrius
Copy link

natrius commented Jan 11, 2022

It seems like link does support it in V3 already. https://linkify.js.org/docs/linkifyjs.html#linkifyregistercustomprotocol-str

So, is it likely this gets implemented somewhat soon?

Asking because mumble://[username[:password]@]<address>[:port]/[channelpath]?version=<serverversion>[&title=<servername>][&url=<serverurl>] does not work at all currenty (it does not get translated to https like the example in the first post)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants