-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accessibility?/UX] Default-generated user icons smehow feel unpleasant to look at #14433
Comments
Do you have resistFingerprinting enabled in your Firefox? Enabling that causes data read from canvases to look like random stripes like you have found. Default generated avatars are actually meant to just be solid colours generated by means of canvases for ability to integrate with various web APIs such as the Notifications API which need an image url |
Interesting, that appears to be indeed the issue. But since allowing canvas access just turns the avatars into solid colors, why isn't riot just using plain background color divs? Seems like it's quite unnecessary to even require canvas access for this |
Because things like the Notifications API do not support that https://developer.mozilla.org/en-US/docs/Web/API/notification/Notification
So to be able to show that same icon in the notification it must be done in canvas |
Couldn't the parts in the riot UI still use the div approach, or is that too much effort to implement? Because then it would at least look right everywhere but the notifications (which I have disabled anyway, not sure how common that is and whether that justifies a separate code path) |
Having to make sure that two different codepaths for one underlying feature work just sounds brittle. It isn't the only place where canvases are needed so working around a browser with broken canvases sounds like a waste of time |
Ok, then I'll close this. (even though from a user side I am kind of hoping you rethink this some day, but up to you) |
Canvases are required for local thumbnailing such as required in e2ee rooms and for videos, its especially bad when the browser returns false data rather than erroring like it used to. Firefox lets you whitelist sites nowadays though |
See #14419 (comment) to allow only Riot / Element to access canvas data. |
(This issue is forwarded from here: matrix-org/synapse#7826 )
Description
I don't know if it's just me, but I find the default-generated user icons are straining/painful to look at. I'm not a scientist so I am not sure why exactly this is, but I have identified a way to improve it:
Current generated icon:
Manual edit of mine that somehow feels way better for me (I just made the stripes 6px wide, from previously 1px):
I have no idea if it's just me, or why exactly these larger stripes are better. But at the chance that I'm not alone with this, I am hereby suggesting to collect more feedback from others and consider changing it because I find the current icons really strangely unpleasant to look at. So if I'm not alone, it definitely sounds like worth changing.
Steps to reproduce
(screenshots see above)
Version information
The text was updated successfully, but these errors were encountered: