Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New design for the @ mention pills #2439

Open
DantrazTrev opened this issue May 18, 2021 · 2 comments
Open

New design for the @ mention pills #2439

DantrazTrev opened this issue May 18, 2021 · 2 comments

Comments

@DantrazTrev
Copy link

DantrazTrev commented May 18, 2021

Is your suggestion related to a problem? Please describe.

The @ mention pills and the room reference look nearly identical to the room reference

image

There is only one visible distinction of a trailing : that is added if the mention is at the start and is removable.

Describe the solution you'd like.

A redesign for the @ pills that are a bit more distinguishable maybe remove the background and make it bolder?

image

Describe alternatives you've considered.

Not really sure about the designs so there should be better ones than the suggested

@MadLittleMods
Copy link

This may only be a problem with dark theme.

The contrast and differentiation in the light theme seems adequate to me.


For reference, pills just got a fresh new update: matrix-org/matrix-react-sdk#10417 but I don't think that addressed dark theme colors/contrast.

@weeman1337
Copy link

weeman1337 commented Apr 20, 2023

Recent changes did only update the pill logic not the UI.
As far as I know, pills should get a new UI when iterating Element X designs.

@t3chguy t3chguy transferred this issue from element-hq/element-web Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants