Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Mention a user in message #2066

Closed
18 tasks done
VolkerJunginger opened this issue Sep 22, 2023 · 8 comments
Closed
18 tasks done

[Story] Mention a user in message #2066

VolkerJunginger opened this issue Sep 22, 2023 · 8 comments

Comments

@VolkerJunginger
Copy link
Contributor

VolkerJunginger commented Sep 22, 2023

Story

As a user I want to mention an other user in a message so that I can make sure that user might not miss my important message.

Figma link: TBD

Acceptance criteria

In general:

  • Only room-members can be mentioned in a room
  • One can not mention themself
  • If a users have been blocked they cannot be mentioned

Creating a mention

  • typing @ + mid into the composer creates a mention (@manuroe is that right?)

Suggesting Users to be mentioned

  • Typing "@" + an other letter into the composer opens a view with suggestions for room-members that the user is allowed to mention
  • with each letter the suggestions get better
  • The suggested users are shown w. avatar and name
  • @room mentions all room members
  • @room mentions only appear in the suggestions if the user has the right to trigger room notifications
  • If the user taps on a suggestion a "mention-pill" is shown in the composer

Size estimate

M

Open Questions

Subtasks

Android

  1. A-Pills A-Rich-Text-Editor T-Enhancement Z-Labs
  2. A-Pills A-Rich-Text-Editor T-Enhancement X-Needs-Design
    jmartinesp
  3. A-Pills A-Timeline T-Enhancement
  4. A-Composer T-Task
    jmartinesp

iOS

  1. A-Pills T-Enhancement
    Velin92
  2. A-Pills A-Rich-Text-Editor T-Enhancement X-Needs-Design
    Velin92
  3. A-Pills A-Rich-Text-Editor T-Enhancement
  4. A-Pills A-Rich-Text-Editor O-Occasional S-Major T-Defect X-Needs-Design Z-Schedule
    Velin92
  5. A-Pills A-Rich-Text-Editor T-Enhancement
  6. T-Task

Rust

  1. A-Notification A-Room-List A-Timeline X-Needs-Rust Z-Schedule
    Velin92
  2. A-Notification A-Room-List A-Timeline X-Needs-Rust Z-Schedule
    Velin92

RTE

  1. A-Rich-Text-Editor Rust T-Enhancement
  2. A-Rich-Text-Editor T-Enhancement iOS
  3. A-Rich-Text-Editor Android T-Enhancement

Design

  • QA signoff on completion
  • Design signoff on completion
  • Product signoff on completion

Out of scope

@Velin92
Copy link
Member

Velin92 commented Sep 28, 2023

Should the @room pill have the "room" string be localised? I imagine that it should still be triggered by explicitly typing "@room" (since this is how is interpreted by all the matrix clients) however i wonder if the pill itself, being a different view, should render the word room localised.

@VolkerJunginger

@VolkerJunginger
Copy link
Contributor Author

VolkerJunginger commented Sep 29, 2023

you mean @raum. No, seems funny to me.

@Velin92
Copy link
Member

Velin92 commented Sep 29, 2023

Perfect then I'll keep it as @room in the text inside the pill for all languages

@Velin92
Copy link
Member

Velin92 commented Oct 12, 2023

Regarding instead the @room suggestion? In El-iOS it is also referred as "Everyone" but is not localised. Should it be localised? This is the string I am referring to
Simulator Screenshot - iPhone 14 - 2023-10-12 at 15 50 35

@VolkerJunginger

@Velin92
Copy link
Member

Velin92 commented Oct 12, 2023

Regarding instead the @room suggestion? In El-iOS it is also referred as "Everyone" but is not localised. Should it be localised? This is the string I am referring to Simulator Screenshot - iPhone 14 - 2023-10-12 at 15 50 35

@VolkerJunginger

Had a chat with @VolkerJunginger about this we decided to try a localised approach.
So if we for example have the app in German, that name will be displayed as "Alle", this means that also looking fror @alle should give you this suggestion.
So botht the string and the suggestion should be localised (of course only if such localisation exists).
@ganfra

@jmartinesp

This comment was marked as resolved.

@Velin92
Copy link
Member

Velin92 commented Oct 16, 2023

So botht the string and the suggestion should be localised (of course only if such localisation exists). @ganfra

That could be a bit problematic: if the user is using a language that didn't include a translation for this shortcut and then it did after an update, they'll try to type @room again an they won't understand why it's not working, and believe it's broken. Maybe we should try to include both the translated and the original one?

the idea is that @room always works, is the additional @everyone that should be localised. (on legacy El-iOS and El web the @room mention works with both the @room tag and the @everyone tag)

@Velin92
Copy link
Member

Velin92 commented Oct 16, 2023

Also of course @room is not localised since is a default matrix mention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants