Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message Management API for Peer Channels will not be accessible via the "Master Bearer Token" #10

Open
AustEcon opened this issue Dec 2, 2021 · 0 comments

Comments

@AustEcon
Copy link
Contributor

AustEcon commented Dec 2, 2021

  • This will bring the messaging API fully back into line with the standard Peer Channels API - i.e. I don't think we should add the extension of allowing a master bearer token to access all channels.

Why?

  • It complicates the implementation potentially all the way down to the db schema and requires more db look-ups on the hot path of message reads and writes.
  • Every use case is already catered to without "Master Bearer Token" read/write access to the messaging APIs.

I am open to reconsidering this feature but there is so much to do - I don't think it's worth the detour for now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant