From 5c6f2aecbbafeda011dce3025dfb601b07cf9e3f Mon Sep 17 00:00:00 2001
From: Christian Clauss <cclauss@me.com>
Date: Tue, 13 Jun 2023 14:21:30 +0200
Subject: [PATCH 1/2] ci: Test current versions of Node.js

---
 .circleci/config.yml | 47 ++++++++++++++++----------------------------
 1 file changed, 17 insertions(+), 30 deletions(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 58fa03a9..4fc5be3e 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -7,20 +7,6 @@ steps-test: &steps-test
   steps:
     - checkout
     - *step-restore-cache
-    - run:
-        name: Install python2 on macos
-        command: |
-          if [ "`uname`" == "Darwin" ]; then
-            if [ ! -f "python-downloads/python-2.7.18-macosx10.9.pkg" ]; then
-              mkdir python-downloads
-              echo 'Downloading Python 2.7.18'
-              curl -O https://dev-cdn.electronjs.org/python/python-2.7.18-macosx10.9.pkg
-              mv python-2.7.18-macosx10.9.pkg python-downloads
-            else
-              echo 'Using Python install from cache'
-            fi
-            sudo installer -pkg python-downloads/python-2.7.18-macosx10.9.pkg -target /
-          fi
     - run:
         name: Install Node
         command: |
@@ -29,16 +15,17 @@ steps-test: &steps-test
               curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.34.0/install.sh | bash
               export NVM_DIR="$HOME/.nvm"
               [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
-              nvm install 12
-              nvm alias default 12
+              nvm install 20
+              nvm alias default 20
               echo 'export NVM_DIR=${HOME}/.nvm' >> $BASH_ENV
               echo "[ -s '${NVM_DIR}/nvm.sh' ] && . '${NVM_DIR}/nvm.sh'" >> $BASH_ENV
               ;;
             Windows*|CYGWIN*|MINGW*|MSYS*)
-              nvm install 12.22.4
-              nvm use 12.22.4
+              nvm install 20
+              nvm use 20
               ;;
           esac
+    - run: node --version
     - run: yarn install --frozen-lockfile --ignore-engines
     - save_cache:
         paths:
@@ -57,21 +44,21 @@ version: 2.1
 orbs:
   win: circleci/windows@1.0.0
 jobs:
-  test-linux-12:
+  test-linux-16:
     docker:
-      - image: cimg/node:12.22
+      - image: cimg/node:16.19
     <<: *steps-test
-  test-linux-14:
+  test-linux-18:
     docker:
-      - image: cimg/node:14.20
+      - image: cimg/node:18.16
     <<: *steps-test
-  test-linux-16:
+  test-linux-20:
     docker:
-      - image: cimg/node:16.18
+      - image: cimg/node:20.3
     <<: *steps-test
   test-mac:
     macos:
-      xcode: "13.3.0"
+      xcode: "14.2.0"
     <<: *steps-test
   test-windows:
     executor:
@@ -83,7 +70,7 @@ jobs:
 
   release:
     docker:
-      - image: cimg/node:14.17
+      - image: cimg/node:20.3
     steps:
       - checkout
       - *step-restore-cache
@@ -97,15 +84,15 @@ workflows:
     # Run the test jobs first, then the release only when all the test jobs are successful
     jobs:
       - test-linux-16
-      - test-linux-12
-      - test-linux-14
+      - test-linux-18
+      - test-linux-20
       - test-mac
       - test-windows
       - release:
           requires:
             - test-linux-16
-            - test-linux-12
-            - test-linux-14
+            - test-linux-18
+            - test-linux-20
             - test-mac
             - test-windows
           filters:

From 1cb2db2dd00a3fca742a097945cd914d7f214477 Mon Sep 17 00:00:00 2001
From: Christian Clauss <cclauss@me.com>
Date: Wed, 14 Jun 2023 07:46:39 +0200
Subject: [PATCH 2/2] Downgrade to Linux Node.js v20.2

---
 .circleci/config.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 4fc5be3e..6f3d31ed 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -54,7 +54,7 @@ jobs:
     <<: *steps-test
   test-linux-20:
     docker:
-      - image: cimg/node:20.3
+      - image: cimg/node:20.2  # See #1085 discussion of node v20.3
     <<: *steps-test
   test-mac:
     macos: