From 261e909b3aa6ce8ca314e8ec4ff2cefec12a948c Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Mon, 30 Jul 2018 10:23:05 -0700 Subject: [PATCH] fix: don't create console window when creating process This commit prevents console windows from being spawned when creating processes to better align with what Windows users expect and should be removed when upgrading to a version that includes https://github.com/nodejs/node/pull/21316 --- deps/uv/src/win/process.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/deps/uv/src/win/process.c b/deps/uv/src/win/process.c index b47f203e9d..6bfecdad7b 100644 --- a/deps/uv/src/win/process.c +++ b/deps/uv/src/win/process.c @@ -1094,6 +1094,9 @@ int uv_spawn(uv_loop_t* loop, process_flags |= DETACHED_PROCESS | CREATE_NEW_PROCESS_GROUP; } + /* Don't create console window. */ + process_flags |= CREATE_NO_WINDOW; + if (!CreateProcessW(application_path, arguments, NULL,