API Working Group

Date Sept 21 2020

Attendees

@nornagon
@zcbenz
@codebytere
@jkleinsc
@MarshallOfSound
@samuelmaddock

Agenda

API Review Requested PRS:
- [WIP] feat: Expose renderer spellcheck API
  - No longer WIP
  - There’s no Web API for this
  - (Sam:) Not convinced this should be on webFrame
  - [ACTION: Sam to discuss this. Where should this go?]
- feat: add support for will-navigate and will-fail-load custom error pages
  - Weird returnValue thing?
  - Prevents white page.
  - Where does the error code go?
    - Netlog
    - Devtools console
  - event.failWith(...)?
  - This doesn’t trigger for fetch
  - Could we expose a NavigationThrottle API directly…?
  - Should be marked as experimental, using the flag feature
- feat: implement allowFileAccess loadExtension option
  - This is ~= the “Allow access to file urls” in the extensions preferences in chrome
  - Should we expose ExtensionPrefs? (For remembering whether allowFileAccess: true across reloads) Not for now.
  - (SamM) Followup to previous responses in PR. Avoid ExtensionPrefs.
- feat: add BrowserWindow.isTabletMode API
  - Seems fine
- feat: add serial api support
  - We should make sure we expose the same surfaces that Chrome does in terms of UI
  - When do the added/removed events start getting emitted…?
  - Let’s not back ourselves into a hole w.r.t. WebUSB which uses similar APIs
  - re-review
- feat: [net] add "credentials" option to net.request
  - Gives the ability to opt out of sending session auth.
  - More closely matches fetch().
  - :check:
- feat: add macOS fast user switching evt
  - Should this be on powerMonitor…?
  - It’s next to lock-screen and unlock-screen
  - Maybe we could have a new “system” module…? [for later followup]
  - :check:
- feat(extensions): expose ExtensionRegistryObserver events in Session
  - Should this maybe be on session.extensions.on(...)?
    - meh
  - NB the pdf extension always emits the “ready” event
  - :check:
- feat: custom toast xml and failure reporting for notifications
  - Can’t be called “error” because that would be a breaking change.
  - :check:
- feat: allow setting SSL config
  - Should mention what the defaults are in the docs.
  - :check:
- [wip] feat: add webFrameMain API to the main process
  - SamM: Figure out lifetime of WebFrame instances (lookup vs hold references).
  - Finalize API in followup next meeting.